Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 297803011: [SyncFS] Run LocalToRemoteSyncer as SyncTask (Closed)

Created:
6 years, 7 months ago by tzik
Modified:
6 years, 7 months ago
Reviewers:
peria, nhiroki
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Run LocalToRemoteSyncer as SyncTask * Replace base class of LocalToRemoteSyncer with SyncTask * Add testing SyncTaskToken. * Clean up LocalToRemoteSyncer implementation. BUG=344769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272494

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Messages

Total messages: 7 (0 generated)
tzik
PTL
6 years, 7 months ago (2014-05-22 05:16:54 UTC) #1
peria
lgtm
6 years, 7 months ago (2014-05-22 05:45:47 UTC) #2
nhiroki
LGTM after fixing compile failure https://codereview.chromium.org/297803011/diff/1/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc File chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc (right): https://codereview.chromium.org/297803011/diff/1/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc#newcode194 chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc:194: nit: there is an ...
6 years, 7 months ago (2014-05-22 08:19:31 UTC) #3
tzik
https://codereview.chromium.org/297803011/diff/1/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc File chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc (right): https://codereview.chromium.org/297803011/diff/1/chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc#newcode194 chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc:194: On 2014/05/22 08:19:32, nhiroki wrote: > nit: there is ...
6 years, 7 months ago (2014-05-23 04:44:58 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 7 months ago (2014-05-23 04:46:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/297803011/20001
6 years, 7 months ago (2014-05-23 04:47:33 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 11:39:33 UTC) #7
Message was sent while issue was closed.
Change committed as 272494

Powered by Google App Engine
This is Rietveld 408576698