Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 297803010: Revert of Fix compilation error when building with clang on Linux. (Closed)

Created:
6 years, 7 months ago by reed2
Modified:
6 years, 7 months ago
Reviewers:
tfarina, bsalomon, reed1
CC:
skia-review_googlegroups.com, rileya1
Visibility:
Public.

Description

Revert of Fix compilation error when building with clang on Linux. (https://codereview.chromium.org/287193006/) Reason for revert: need to revert this along with reverting the big unitmapper cl Original issue's description: > Fix compilation error when building with clang on Linux. > > ../../src/effects/gradients/SkGradientShader.cpp:487:22: error: unused > function 'bitsTo16' [-Werror,-Wunused-function] > static inline U16CPU bitsTo16(unsigned x, const unsigned bits) { > > R=bsalomon@google.com > TEST=make tests > > Committed: http://code.google.com/p/skia/source/detail?r=14835 TBR=bsalomon@google.com,reed@google.com,tfarina@chromium.org NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed2
Created Revert of Fix compilation error when building with clang on Linux.
6 years, 7 months ago (2014-05-22 03:19:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/297803010/1
6 years, 7 months ago (2014-05-22 03:20:24 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 03:20:51 UTC) #3
Message was sent while issue was closed.
Change committed as 14839

Powered by Google App Engine
This is Rietveld 408576698