Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 297803008: Mojo: POSIX: Add a PlatformChannelSendmsgWithHandles(). (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: POSIX: Add a PlatformChannelSendmsgWithHandles(). This wraps sendmsg() and allows FDs to be sent. It will replace PlatformChannelSendHandles(). R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272203

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -18 lines) Patch
M mojo/embedder/platform_channel_pair_posix_unittest.cc View 5 chunks +30 lines, -17 lines 0 comments Download
M mojo/embedder/platform_channel_utils_posix.h View 2 chunks +18 lines, -1 line 0 comments Download
M mojo/embedder/platform_channel_utils_posix.cc View 1 2 3 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-21 22:50:13 UTC) #1
yzshen1
LGTM https://codereview.chromium.org/297803008/diff/20001/mojo/embedder/platform_channel_utils_posix.cc File mojo/embedder/platform_channel_utils_posix.cc (right): https://codereview.chromium.org/297803008/diff/20001/mojo/embedder/platform_channel_utils_posix.cc#newcode86 mojo/embedder/platform_channel_utils_posix.cc:86: DCHECK_GT(num_platform_handles, 0u); nit: It might be good to ...
6 years, 7 months ago (2014-05-21 23:50:02 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/297803008/diff/20001/mojo/embedder/platform_channel_utils_posix.cc File mojo/embedder/platform_channel_utils_posix.cc (right): https://codereview.chromium.org/297803008/diff/20001/mojo/embedder/platform_channel_utils_posix.cc#newcode86 mojo/embedder/platform_channel_utils_posix.cc:86: DCHECK_GT(num_platform_handles, 0u); On 2014/05/21 23:50:02, yzshen1 wrote: > ...
6 years, 7 months ago (2014-05-22 00:21:44 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-22 00:21:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/297803008/40001
6 years, 7 months ago (2014-05-22 00:25:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 09:37:08 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 09:39:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9704)
6 years, 7 months ago (2014-05-22 09:39:45 UTC) #8
viettrungluu
6 years, 7 months ago (2014-05-22 16:36:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r272203 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698