Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 297803005: Revert of Modify sample buffer size for larger displays. (Closed)

Created:
6 years, 7 months ago by scroggo
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com, epoger
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Modify sample buffer size for larger displays. (https://codereview.chromium.org/240433002/) Reason for revert: Sorry, Henrik, but after all the churn, we're reverting :( We are having unrelated DEPS roll issues, and since this may affect layout tests (which I suspect it will because it affects our GMs), we do not want to do anything to further prevent the DEPS roll. The ignored-tests changes are also not correct, leading to redness in our tree. Will you please add the changes from https://codereview.chromium.org/296923002/, and then we'll resubmit once the DEPS roll goes through? TBR=reed NOTREECHECK=True NOTRY=True Original issue's description: > Modify sample buffer size for larger displays. > > Increases the intermediate buffer size for sample pixel indexes, > used in the sample proc function calls. If the operation is bigger > than the buffer it's split into multiple calls, creating overhead. > This would especially impact the performance of SIMD optimizations. > Also, aligns the start address of the buffer to 16 bytes, to enable > more efficient SIMD optimizations. > > Author: henrik.smiding@intel.com > > Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>; > > Committed: http://code.google.com/p/skia/source/detail?r=14825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -86 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +1 line, -60 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 3 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
scroggo
Created Revert of Modify sample buffer size for larger displays.
6 years, 7 months ago (2014-05-21 16:24:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/297803005/1
6 years, 7 months ago (2014-05-21 16:25:33 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 16:25:34 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-21 16:25:34 UTC) #4
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 7 months ago (2014-05-21 16:30:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/297803005/1
6 years, 7 months ago (2014-05-21 16:31:31 UTC) #6
f(malita)
lgtm
6 years, 7 months ago (2014-05-21 16:31:33 UTC) #7
reed1
The CQ bit was unchecked by reed@google.com
6 years, 7 months ago (2014-05-21 16:36:25 UTC) #8
scroggo
On 2014/05/21 16:36:25, reed1 wrote: > The CQ bit was unchecked by mailto:reed@google.com CQ was ...
6 years, 7 months ago (2014-05-21 16:40:53 UTC) #9
borenet
On 2014/05/21 16:40:53, scroggo wrote: > On 2014/05/21 16:36:25, reed1 wrote: > > The CQ ...
6 years, 7 months ago (2014-05-21 17:03:31 UTC) #10
rmistry
On 2014/05/21 17:03:31, borenet wrote: > On 2014/05/21 16:40:53, scroggo wrote: > > On 2014/05/21 ...
6 years, 7 months ago (2014-05-21 17:04:59 UTC) #11
scroggo
On 2014/05/21 17:03:31, borenet wrote: > On 2014/05/21 16:40:53, scroggo wrote: > > On 2014/05/21 ...
6 years, 7 months ago (2014-05-21 18:15:03 UTC) #12
scroggo
6 years, 7 months ago (2014-05-21 18:17:44 UTC) #13
Message was sent while issue was closed.
On 2014/05/21 18:15:03, scroggo wrote:
> On 2014/05/21 17:03:31, borenet wrote:
> > On 2014/05/21 16:40:53, scroggo wrote:
> > > On 2014/05/21 16:36:25, reed1 wrote:
> > > > The CQ bit was unchecked by mailto:reed@google.com
> > > 
> > > CQ was not working, so reed@ submitted this manually:
> > >
> >
>
https://skia.googlesource.com/skia.git/+/b03be0b887facebc9f6a202c43a134728465...
> > 
> > FYI: It looks like this was failing due to a typo:
> > 
> > NOTREECHECK=True
> > 
> > Should have been:
> > 
> > NOTREECHECKS=true
> > 
> > ... I think we need a checkbox or something instead of relying on
human-typed
> > keywords
> 
> +1! I always have to look them up (I think they're in a bug somewhere, not
sure
> if they're documented in a better place). In this case I just copied from
> another CL (which apparently had the typo). I think some kind of checkbox
would
> be nice for someone not doing a revert that needs to use those flags.

Filed skbug.com/2588

Powered by Google App Engine
This is Rietveld 408576698