content/browser/devtools/devtools_resources.gyp - Issue 297803003: Add devtools protocol constants generator to chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_resources.gyp

Issue 297803003: Add devtools protocol constants generator to chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverted drive-by changes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_protocol_constants.gyp ('K') | « content/browser/devtools/devtools_protocol_constants_generator.py ('k') | content/public/browser/devtools_protocol_constants_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_resources.gyp

diff --git a/content/browser/devtools/devtools_resources.gyp b/content/browser/devtools/devtools_resources.gyp

index c4c3a9d195ec41ece23f4449252c7b1031030672..b93355a8390cee792746e74c51e992c0b3ab4e49 100644

--- a/content/browser/devtools/devtools_resources.gyp

+++ b/content/browser/devtools/devtools_resources.gyp

@@ -47,24 +47,27 @@

'action_name': 'devtools_protocol_constants',

'variables': {

'blink_protocol': '../../../third_party/WebKit/Source/devtools/protocol.json',

- 'browser_protocol': 'browser_protocol.json'

+ 'browser_protocol': 'browser_protocol.json',

+ 'generator': '../../public/browser/devtools_protocol_constants_generator.py',

+ 'package': 'content'

'inputs': [

'<(blink_protocol)',

'<(browser_protocol)',

- 'devtools_protocol_constants_generator.py',

+ '<(generator)',

'outputs': [

- '<(SHARED_INTERMEDIATE_DIR)/content/browser/devtools/devtools_protocol_constants.cc',

- '<(SHARED_INTERMEDIATE_DIR)/content/browser/devtools/devtools_protocol_constants.h'

+ '<(SHARED_INTERMEDIATE_DIR)/<(package)/devtools_protocol_constants.cc',

+ '<(SHARED_INTERMEDIATE_DIR)/<(package)/devtools_protocol_constants.h'

'action':[

'python',

- 'devtools_protocol_constants_generator.py',

+ '<(generator)',

+ '<(package)',

+ '<(SHARED_INTERMEDIATE_DIR)/<(package)/devtools_protocol_constants.cc',

+ '<(SHARED_INTERMEDIATE_DIR)/<(package)/devtools_protocol_constants.h',

'<(blink_protocol)',

'<(browser_protocol)',

- '<(SHARED_INTERMEDIATE_DIR)/content/browser/devtools/devtools_protocol_constants.cc',

- '<(SHARED_INTERMEDIATE_DIR)/content/browser/devtools/devtools_protocol_constants.h',

'message': 'Generating DevTools protocol constants from <(blink_protocol)'

}