Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297803003: Add devtools protocol constants generator to chrome/ (Closed)

Created:
6 years, 7 months ago by eustas
Modified:
6 years, 7 months ago
Reviewers:
jam, pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add devtools protocol constants generator to chrome/ BUG=373325 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272570

Patch Set 1 #

Patch Set 2 : Move devtools protocol constants generator to content/browser/public #

Patch Set 3 : Reverted drive-by changes #

Total comments: 8

Patch Set 4 : Cleaned-up gyp file #

Patch Set 5 : Fix android builds #

Patch Set 6 : fix android build #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -228 lines) Patch
A chrome/browser/devtools/devtools_protocol_constants.gyp View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/chrome_debugger.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
D content/browser/devtools/devtools_protocol_constants_generator.py View 1 1 chunk +0 lines, -199 lines 0 comments Download
M content/browser/devtools/devtools_resources.gyp View 1 2 3 4 5 6 1 chunk +10 lines, -7 lines 0 comments Download
A + content/public/browser/devtools_protocol_constants_generator.py View 1 2 6 chunks +34 lines, -22 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
eustas
6 years, 7 months ago (2014-05-21 07:45:02 UTC) #1
pfeldman
lgtm
6 years, 7 months ago (2014-05-21 16:35:32 UTC) #2
jam
it seems unfortunate to have two copies of this script. can we share it somehow?
6 years, 7 months ago (2014-05-21 16:58:53 UTC) #3
pfeldman
We could host it in content if you don't mind.
6 years, 7 months ago (2014-05-21 17:02:40 UTC) #4
jam
On 2014/05/21 17:02:40, pfeldman wrote: > We could host it in content if you don't ...
6 years, 7 months ago (2014-05-21 23:45:15 UTC) #5
eustas
On 2014/05/21 23:45:15, jam wrote: > On 2014/05/21 17:02:40, pfeldman wrote: > > We could ...
6 years, 7 months ago (2014-05-22 12:20:03 UTC) #6
jam
On 2014/05/22 12:20:03, eustas wrote: > On 2014/05/21 23:45:15, jam wrote: > > On 2014/05/21 ...
6 years, 7 months ago (2014-05-22 23:36:42 UTC) #7
pfeldman
https://codereview.chromium.org/297803003/diff/40001/chrome/browser/devtools/devtools_protocol_constants.gyp File chrome/browser/devtools/devtools_protocol_constants.gyp (right): https://codereview.chromium.org/297803003/diff/40001/chrome/browser/devtools/devtools_protocol_constants.gyp#newcode11 chrome/browser/devtools/devtools_protocol_constants.gyp:11: '../../../third_party/WebKit/public/blink_devtools.gyp:blink_generate_devtools_grd', You don't need this dependency. https://codereview.chromium.org/297803003/diff/40001/chrome/browser/devtools/devtools_protocol_constants.gyp#newcode14 chrome/browser/devtools/devtools_protocol_constants.gyp:14: 'grit_out_dir': ...
6 years, 7 months ago (2014-05-23 09:47:57 UTC) #8
eustas
https://codereview.chromium.org/297803003/diff/40001/chrome/browser/devtools/devtools_protocol_constants.gyp File chrome/browser/devtools/devtools_protocol_constants.gyp (right): https://codereview.chromium.org/297803003/diff/40001/chrome/browser/devtools/devtools_protocol_constants.gyp#newcode11 chrome/browser/devtools/devtools_protocol_constants.gyp:11: '../../../third_party/WebKit/public/blink_devtools.gyp:blink_generate_devtools_grd', On 2014/05/23 09:47:58, pfeldman wrote: > You don't ...
6 years, 7 months ago (2014-05-23 09:58:05 UTC) #9
pfeldman
lgtm
6 years, 7 months ago (2014-05-23 10:02:12 UTC) #10
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 7 months ago (2014-05-23 10:53:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/297803003/60001
6 years, 7 months ago (2014-05-23 10:55:09 UTC) #12
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 7 months ago (2014-05-23 13:50:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/297803003/80001
6 years, 7 months ago (2014-05-23 13:50:49 UTC) #14
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 7 months ago (2014-05-23 15:20:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/297803003/110001
6 years, 7 months ago (2014-05-23 15:20:52 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 18:50:27 UTC) #17
Message was sent while issue was closed. 
Change committed as 272570

Powered by Google App Engine
This is Rietveld 408576698