Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2978013002: Migrate test block 1 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by jcollins
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate test block 1 to Dart 2.0. This change makes big_integer_arith_vm_test strong-mode compatible, and allows dartdevc/dart2js to build and run big_integer tests where they can. New issue 30170 filed to track DDC big integer handling. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/70935d97c542c0200bc5cc43dbbdf5ace9ac5025

Patch Set 1 #

Patch Set 2 : rebase to repatched status/utilities #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2567 lines) Patch
D tests/corelib/apply2_test.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D tests/corelib/apply3_test.dart View 1 chunk +0 lines, -69 lines 0 comments Download
D tests/corelib/apply4_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib/apply5_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/corelib/big_integer_arith_vm_test.dart View 1 chunk +0 lines, -447 lines 0 comments Download
D tests/corelib/big_integer_huge_mul_vm_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/corelib/big_integer_parsed_arith_vm_test.dart View 1 chunk +0 lines, -601 lines 0 comments Download
M tests/corelib/corelib.status View 4 chunks +0 lines, -9 lines 0 comments Download
A + tests/corelib_2/apply2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/apply3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/apply4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/apply5_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/big_integer_arith_vm_test.dart View 6 chunks +24 lines, -24 lines 0 comments Download
A + tests/corelib_2/big_integer_huge_mul_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/big_integer_parsed_arith_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 chunk +24 lines, -0 lines 0 comments Download
D tests/corelib_strong/apply2_test.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D tests/corelib_strong/apply3_test.dart View 1 chunk +0 lines, -69 lines 0 comments Download
D tests/corelib_strong/apply4_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib_strong/big_integer_arith_vm_test.dart View 1 chunk +0 lines, -444 lines 0 comments Download
D tests/corelib_strong/big_integer_huge_mul_vm_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/corelib_strong/big_integer_parsed_arith_vm_test.dart View 1 chunk +0 lines, -601 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jcollins
My first test block migration -- code changes are relatively minor, only impacting big_integer_arith_vm_test. I'm ...
3 years, 5 months ago (2017-07-14 21:13:30 UTC) #2
Bob Nystrom
LGTM!
3 years, 5 months ago (2017-07-17 21:34:20 UTC) #4
jcollins
3 years, 5 months ago (2017-07-19 14:55:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
70935d97c542c0200bc5cc43dbbdf5ace9ac5025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698