Resynthesize factory constructors from Kernel.

Resynthesize factory constructors from Kernel.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/592357028e5e4093b9b7d4ef18101a7806c2ec77

[Paul Berry, 2017-07-14 20:31:02]

lgtm

Comment below is a suggestion; your call whether to follow it or not.

https://codereview.chromium.org/2977963003/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2977963003/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:1998: final kernel.Constructor
_kernelConstructor;
It seems unfortunate to bloat the memory footprint of the element model just
because a constructor can take two different possible forms.  How about if
instead we just do:

final kernel.Member _kernel;

And use "is" checks to distinguish factory and non-factory constructors?

[scheglov, 2017-07-14 21:04:29]

Description was changed from

==========
Resynthesize factory constructors from Kernel.

R=paulberry@google.com
BUG=
==========

to

==========
Resynthesize factory constructors from Kernel.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/592357028e5e4093b9b7d4ef18101a7806c2ec77
==========

[scheglov, 2017-07-14 21:04:31]

Committed patchset #1 (id:1) manually as
592357028e5e4093b9b7d4ef18101a7806c2ec77 (presubmit successful).