Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297793005: Revert of Simplified android_builder and moved internal-only methods to internal module (Closed)

Created:
6 years, 7 months ago by luqui
Modified:
6 years, 7 months ago
Reviewers:
navabi1, agable, navabi, zty
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Revert of Simplified android_builder and moved internal-only methods to internal module (https://codereview.chromium.org/296723004/) Reason for revert: I needed to coordinate this with master restarts. Original issue's description: > Simplified android_builder and moved internal-only methods to internal module > > Internal side https://chromereviews.googleplex.com/42137013/ > and https://chromereviews.googleplex.com/45097017/ > > BUG=375007 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=272612 TBR=navabi@chromium.org,zty@chromium.org,navabi@google.com NOTREECHECKS=true NOTRY=true BUG=375007 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=272632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3574 lines, -200 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 5 chunks +86 lines, -9 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json View 3 chunks +2 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json View 3 chunks +2 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json View 3 chunks +2 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.py View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/linux.json View 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/mac.json View 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/path/example.expected/win.json View 1 chunk +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/android/android_builder.py View 1 chunk +121 lines, -12 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/arm_builder.json View 1 chunk +268 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/arm_builder_rel.json View 1 chunk +268 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/clang_builder.json View 1 chunk +300 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/clang_builder_findbugs_failure.json View 1 chunk +323 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/clang_release_builder.json View 1 chunk +307 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/component_builder.json View 1 chunk +268 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/dartium_builder.json View 1 chunk +201 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/main_builder.json View 1 chunk +268 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/mipsel_builder.json View 1 chunk +264 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/try_builder.json View 1 chunk +313 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/x86_builder.json View 1 chunk +268 lines, -0 lines 0 comments Download
A scripts/slave/recipes/android/android_builder.expected/x86_try_builder.json View 1 chunk +313 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
luqui
Created Revert of Simplified android_builder and moved internal-only methods to internal module
6 years, 7 months ago (2014-05-23 23:10:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luqui@chromium.org/297793005/1
6 years, 7 months ago (2014-05-23 23:10:54 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 23:10:55 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-23 23:10:56 UTC) #4
agable
On 2014/05/23 23:10:56, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 7 months ago (2014-05-23 23:18:00 UTC) #5
luqui
The CQ bit was checked by luqui@chromium.org
6 years, 7 months ago (2014-05-23 23:18:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luqui@chromium.org/297793005/1
6 years, 7 months ago (2014-05-23 23:18:27 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 23:19:45 UTC) #8
Message was sent while issue was closed. 
Change committed as 272632

Powered by Google App Engine
This is Rietveld 408576698