Issue 297793004: Work on the Android GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297793004: Work on the Android GN build. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, cbentzel+watch_chromium.org, tdresser+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Work on the Android GN build. Fills out more targets in the Android build. BUG= R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272574

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -11 lines)			Patch
M	BUILD.gn	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	build/config/crypto.gni	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/BUILD.gn	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	ui/base/BUILD.gn	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	ui/events/BUILD.gn	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	ui/gl/BUILD.gn	View	1	3 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

It looks like forther progress is blocked on ../../build/jar_file_jni_generator.gypi Do you think that's hard to ...

6 years, 7 months ago (2014-05-23 18:16:34 UTC) #1

cjhopman

lgtm. jar_file_jni_generator.gypi to GN is pretty straightforward, I'll prioritize that. https://codereview.chromium.org/297793004/diff/1/ui/gl/BUILD.gn File ui/gl/BUILD.gn (right): https://codereview.chromium.org/297793004/diff/1/ui/gl/BUILD.gn#newcode307 ...

6 years, 7 months ago (2014-05-23 18:24:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r272574.

Expand Messages | Collapse Messages

Issue 297793004: Work on the Android GN build. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages