Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Issue 2977893002: Undeprecate IncompleteError. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/body_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
index 18938933854daecfa6147c488c3a66b5724caad4..f69a0bf9ef20d82e300ad5307ca913e9cdaeef31 100644
--- a/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/body_builder.dart
@@ -1063,8 +1063,8 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
{bool isQualified: false, PrefixBuilder prefix}) {
Builder builder = scope.lookup(name, offsetForToken(token), uri);
if (builder != null && member.isField && builder.isInstanceMember) {
- return new deprecated_IncompleteError(this, token,
- "Can't access 'this' in a field initializer to read '$name'.");
+ return new IncompleteError(this, token,
+ fasta.templateThisAccessInFieldInitializer.withArguments(name));
}
if (builder == null || (!isInstanceContext && builder.isInstanceMember)) {
Name n = new Name(name, library.library);
@@ -2375,8 +2375,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
if (context.isScopeReference && isInstanceContext) {
push(new ThisAccessor(this, token, inInitializer));
} else {
- push(new deprecated_IncompleteError(
- this, token, "Expected identifier, but got 'this'."));
+ push(new IncompleteError(this, token, fasta.messageThisAsIdentifier));
}
}
@@ -2388,8 +2387,7 @@ class BodyBuilder extends ScopeListener<JumpTarget> implements BuilderHelper {
member.transformerFlags |= TransformerFlag.superCalls;
push(new ThisAccessor(this, token, inInitializer, isSuper: true));
} else {
- push(new deprecated_IncompleteError(
- this, token, "Expected identifier, but got 'super'."));
+ push(new IncompleteError(this, token, fasta.messageSuperAsIdentifier));
}
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/fasta_codes_generated.dart ('k') | pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698