Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: milo/buildsource/buildbot/datastore.go

Issue 2977863002: [milo] Refactor all html knowledge out of backends. (Closed)
Patch Set: now with case insensitivity Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/buildsource/buildbot/buildinfo.go ('k') | milo/buildsource/buildbot/grpc.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/buildsource/buildbot/datastore.go
diff --git a/milo/buildsource/buildbot/datastore.go b/milo/buildsource/buildbot/datastore.go
index 8e3eef06b2545d9845718fe2a983e8fcfd2d7974..55b4bc5761c582686348a547463cb1e5ccd0ed36 100644
--- a/milo/buildsource/buildbot/datastore.go
+++ b/milo/buildsource/buildbot/datastore.go
@@ -44,13 +44,13 @@ func getBuildQueryBatcher(c context.Context) *datastore.Batcher {
// along with a cursor. We pass the limit here and apply it to the query as
// an optimization because then we can create a build container of that size.
func runBuildsQuery(c context.Context, q *datastore.Query, limit int32) (
- []*buildbotBuild, *datastore.Cursor, error) {
+ []*buildbotBuild, datastore.Cursor, error) {
if limit != 0 {
q = q.Limit(limit)
}
builds := make([]*buildbotBuild, 0, limit)
- var nextCursor *datastore.Cursor
+ var nextCursor datastore.Cursor
err := getBuildQueryBatcher(c).Run(
c, q, func(build *buildbotBuild, getCursor datastore.CursorCB) error {
builds = append(builds, build)
@@ -58,7 +58,7 @@ func runBuildsQuery(c context.Context, q *datastore.Query, limit int32) (
if err != nil {
return err
}
- nextCursor = &tmpCursor
+ nextCursor = tmpCursor
return nil
})
return builds, nextCursor, err
« no previous file with comments | « milo/buildsource/buildbot/buildinfo.go ('k') | milo/buildsource/buildbot/grpc.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698