Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: milo/frontend/config.go

Issue 2977863002: [milo] Refactor all html knowledge out of backends. (Closed)
Patch Set: now with case insensitivity Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/frontend/buildbot_data.go ('k') | milo/frontend/console/console.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/frontend/config.go
diff --git a/milo/frontend/config.go b/milo/frontend/config.go
deleted file mode 100644
index 1a0c3a0417031dcd299e8bca0c24e3456eb0c435..0000000000000000000000000000000000000000
--- a/milo/frontend/config.go
+++ /dev/null
@@ -1,76 +0,0 @@
-// Copyright 2015 The LUCI Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-package frontend
-
-import (
- "net/http"
-
- "cloud.google.com/go/datastore"
- "google.golang.org/appengine"
-
- "github.com/luci/luci-go/common/logging"
- "github.com/luci/luci-go/milo/common"
- "github.com/luci/luci-go/server/router"
- "github.com/luci/luci-go/server/templates"
-)
-
-// ConfigsHandler renders the page showing the currently loaded set of luci-configs.
-func ConfigsHandler(c *router.Context) {
- projects, err := common.GetAllProjects(c.Context)
- if err != nil {
- common.ErrorPage(
- c, http.StatusInternalServerError,
- "Error while getting projects: "+err.Error())
- return
- }
- sc, err := common.GetCurrentServiceConfig(c.Context)
- if err != nil && err != datastore.ErrNoSuchEntity {
- common.ErrorPage(
- c, http.StatusInternalServerError,
- "Error while getting service config: "+err.Error())
- return
- }
-
- templates.MustRender(c.Context, c.Writer, "pages/configs.html", templates.Args{
- "Projects": projects,
- "ServiceConfig": sc,
- })
-}
-
-// UpdateHandler is an HTTP handler that handles configuration update requests.
-func UpdateConfigHandler(ctx *router.Context) {
- c, h := ctx.Context, ctx.Writer
- // Needed to access the PubSub API
- c = appengine.WithContext(c, ctx.Request)
- projErr := common.UpdateProjectConfigs(c)
- if projErr != nil {
- logging.WithError(projErr).Errorf(c, "project update handler encountered error")
- }
- settings, servErr := common.UpdateServiceConfig(c)
- if servErr != nil {
- logging.WithError(servErr).Errorf(c, "service update handler encountered error")
- } else {
- servErr = common.EnsurePubSubSubscribed(c, settings)
- if servErr != nil {
- logging.WithError(servErr).Errorf(
- c, "pubsub subscriber handler encountered error")
- }
- }
- if projErr != nil || servErr != nil {
- h.WriteHeader(http.StatusInternalServerError)
- return
- }
- h.WriteHeader(http.StatusOK)
-}
« no previous file with comments | « milo/frontend/buildbot_data.go ('k') | milo/frontend/console/console.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698