Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: milo/common/utils.go

Issue 2977863002: [milo] Refactor all html knowledge out of backends. (Closed)
Patch Set: now with case insensitivity Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/common/middleware.go ('k') | milo/frontend/buildbot_data.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/common/utils.go
diff --git a/milo/common/utils.go b/milo/common/utils.go
deleted file mode 100644
index f9bdcc229d16632a6ac69e56312ef847e30ba0a1..0000000000000000000000000000000000000000
--- a/milo/common/utils.go
+++ /dev/null
@@ -1,44 +0,0 @@
-// Copyright 2015 The LUCI Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-package common
-
-import (
- "fmt"
- "net/http"
- "strconv"
-)
-
-// GetLimit extracts the "limit", "numbuilds", or "num_builds" http param from
-// the request, or returns "-1" implying no limit was specified.
-func GetLimit(r *http.Request) (int, error) {
- sLimit := r.FormValue("limit")
- if sLimit == "" {
- sLimit = r.FormValue("numbuilds")
- if sLimit == "" {
- sLimit = r.FormValue("num_builds")
- if sLimit == "" {
- return -1, nil
- }
- }
- }
- limit, err := strconv.Atoi(sLimit)
- if err != nil {
- return -1, fmt.Errorf("limit parameter value %q is not a number: %s", sLimit, err)
- }
- if limit < 0 {
- return -1, fmt.Errorf("limit parameter value %q is less than 0", sLimit)
- }
- return limit, nil
-}
« no previous file with comments | « milo/common/middleware.go ('k') | milo/frontend/buildbot_data.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698