Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: milo/buildsource/buildbucket/builder.go

Issue 2977863002: [milo] Refactor all html knowledge out of backends. (Closed)
Patch Set: seems to work :) Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/buildsource/buildbucket/builder.go
diff --git a/milo/buildsource/buildbucket/builder.go b/milo/buildsource/buildbucket/builder.go
index 4bbfee914bfd96f5e03a0c997fc77b544d0aee40..b079390745506d321e5eb68f2726e9351c45830f 100644
--- a/milo/buildsource/buildbucket/builder.go
+++ b/milo/buildsource/buildbucket/builder.go
@@ -305,3 +305,13 @@ func (a newBuildsFirst) Swap(i, j int) { a[i], a[j] = a[j], a[i] }
func (a newBuildsFirst) Less(i, j int) bool {
return a[i].PendingTime.Started.After(a[j].PendingTime.Started)
}
+
+// GetBuilder is used by buildsource.BuilderID.Get to obtain the resp.Builder.
+func GetBuilder(ctx context.Context, bucket, builder string, limit int) (*resp.Builder, error) {
+ // TODO(iannucci): set buildbucket host?
Ryan Tseng 2017/07/13 22:00:46 buildbucket:milo is a 1:1 relationship atm, so it'
iannucci 2017/07/14 19:00:22 yeah hence todo :)
+ var query builderQuery
Ryan Tseng 2017/07/13 22:00:46 nit: inline
iannucci 2017/07/14 19:00:22 Done.
+ query.Bucket = bucket
+ query.Builder = builder
+ query.Limit = limit
+ return builderImpl(ctx, query)
+}

Powered by Google App Engine
This is Rietveld 408576698