Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: milo/buildsource/buildbot/build_test.go

Issue 2977863002: [milo] Refactor all html knowledge out of backends. (Closed)
Patch Set: seems to work :) Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/buildsource/buildbot/build_test.go
diff --git a/milo/buildsource/buildbot/build_test.go b/milo/buildsource/buildbot/build_test.go
index 03c1ffa9f3a1310b360e72b67f2b873a0bf54ffe..42f8719a019ebf83ed0bd0dc792692188a145c89 100644
--- a/milo/buildsource/buildbot/build_test.go
+++ b/milo/buildsource/buildbot/build_test.go
@@ -23,8 +23,13 @@ import (
"strings"
"testing"
+ "golang.org/x/net/context"
+
+ . "github.com/smartystreets/goconvey/convey"
+
"github.com/luci/gae/impl/memory"
ds "github.com/luci/gae/service/datastore"
+
"github.com/luci/luci-go/common/clock/testclock"
memcfg "github.com/luci/luci-go/common/config/impl/memory"
"github.com/luci/luci-go/luci_config/server/cfgclient/backend/testconfig"
@@ -32,9 +37,7 @@ import (
"github.com/luci/luci-go/server/auth/authtest"
"github.com/luci/luci-go/server/auth/identity"
- "golang.org/x/net/context"
-
- . "github.com/smartystreets/goconvey/convey"
+ "github.com/luci/luci-go/milo/common"
)
var generate = flag.Bool("test.generate", false, "Generate expectations instead of running tests.")
@@ -103,7 +106,7 @@ func TestBuild(t *testing.T) {
Internal: true,
})
_, err := getBuild(c, "fake", "fake", 1)
- So(err, ShouldResemble, errNotAuth)
+ So(common.ErrorTag.In(err), ShouldEqual, common.CodeUnauthorized)
})
})
}

Powered by Google App Engine
This is Rietveld 408576698