[milo] Refactor all html knowledge out of backends.

milo/buildsource/buildbucket/builder_test.go

 // Copyright 2016 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 40 matching lines @@
                 _, err := common.UpdateServiceConfig(c)
                 So(err, ShouldBeNil)
 
                 for _, tc := range testCases {
                         tc := tc
                         Convey(fmt.Sprintf("%s:%s", tc.bucket, tc.builder), func() {
                                 expectationFilePath := filepath.Join("expectations", tc.bucket, tc.builder+".json")
                                 err := os.MkdirAll(filepath.Dir(expectationFilePath), 0777)
                                 So(err, ShouldBeNil)
 
-                                actual, err := builderImpl(c,
-                                        builderQuery{
-                                                Bucket:  tc.bucket,
-                                                Builder: tc.builder,
-                                                Limit:   0,
-                                        })
+                                actual, err := GetBuilder(c, tc.bucket, tc.builder, 0)
                                 So(err, ShouldBeNil)
                                 actualJSON, err := json.MarshalIndent(actual, "", "  ")
                                 So(err, ShouldBeNil)
 
                                 if *generate {
                                         err := ioutil.WriteFile(expectationFilePath, actualJSON, 0777)
                                         So(err, ShouldBeNil)
                                 } else {
                                         expectedJSON, err := ioutil.ReadFile(expectationFilePath)
                                         So(err, ShouldBeNil)
                                         So(string(actualJSON), ShouldEqual, string(expectedJSON))
                                 }
                         })
                 }
         })
 }
 
 var bktConfig = `
 buildbucket: {
         host: "debug"
         project: "debug"
 }
 `
 
 var bktConfigFull = map[string]memcfg.ConfigSet{
         "services/luci-milo-dev": {
                 "settings.cfg": bktConfig,
         },
 }