[milo] Refactor all html knowledge out of backends.

milo/buildsource/buildbot/build_test.go

 // Copyright 2016 The LUCI Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //      http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 package buildbot
 
 import (
         "encoding/json"
         "flag"
         "fmt"
         "io/ioutil"
         "path"
         "strings"
         "testing"
 
+        "golang.org/x/net/context"
+
+        . "github.com/smartystreets/goconvey/convey"
+
         "github.com/luci/gae/impl/memory"
         ds "github.com/luci/gae/service/datastore"
+
         "github.com/luci/luci-go/common/clock/testclock"
         memcfg "github.com/luci/luci-go/common/config/impl/memory"
         "github.com/luci/luci-go/luci_config/server/cfgclient/backend/testconfig"
         "github.com/luci/luci-go/server/auth"
         "github.com/luci/luci-go/server/auth/authtest"
         "github.com/luci/luci-go/server/auth/identity"
 
-        "golang.org/x/net/context"
-
-        . "github.com/smartystreets/goconvey/convey"
+        "github.com/luci/luci-go/milo/common"
 )
 
 var generate = flag.Bool("test.generate", false, "Generate expectations instead of running tests.")
 
 func load(name string) ([]byte, error) {
         filename := strings.Join([]string{"expectations", name}, "/")
         return ioutil.ReadFile(filename)
 }
 
 func shouldMatchExpectationsFor(actualContents interface{}, expectedFilename ...interface{}) string {
@@ skipping 48 matching lines @@
                 }
 
                 Convey(`Disallow anonomyous users from accessing internal builds`, func() {
                         ds.Put(c, &buildbotBuild{
                                 Master:      "fake",
                                 Buildername: "fake",
                                 Number:      1,
                                 Internal:    true,
                         })
                         _, err := getBuild(c, "fake", "fake", 1)
-                        So(err, ShouldResemble, errNotAuth)
+                        So(common.ErrorTag.In(err), ShouldEqual, common.CodeUnauthorized)
                 })
         })
 }
 
 var internalConfig = `
 buildbot: {
         internal_reader: "googlers"
         public_subscription: "projects/luci-milo/subscriptions/buildbot-public"
         internal_subscription: "projects/luci-milo/subscriptions/buildbot-private"
 }
 `
 
 var bbAclConfigs = map[string]memcfg.ConfigSet{
         "services/luci-milo": {
                 "settings.cfg": internalConfig,
         },
 }