LayoutTests/media/video-controls-hide-on-move-outside-controls.html - Issue 297783004: Implement heuristic for showing media controls during playback w/o a mouse

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-controls-hide-on-move-outside-controls.html

Issue 297783004: Implement heuristic for showing media controls during playback w/o a mouse (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: IgnoreSelfHover -> IgnoreVideoHover; Tweak comment. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/media/video-controls-focus-movement-on-hide.html ('K') | « LayoutTests/media/video-controls-focus-movement-on-hide-expected.txt ('k') | LayoutTests/media/video-controls-hide-on-move-outside-controls-expected.txt » ('j') | LayoutTests/media/video-controls-show-on-focus.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <style>

	4 #no-video-media {

	5 width: 320px;

	6 height: 240px;

	7 }

	8 </style>

	9 <script src=video-test.js></script>

	10 <script src=media-file.js></script>

	11 <script src=media-controls.js></script>

	12 <script>

	13 var controls;

	14

	15 function runTest()

	16 {

	17 video = document.getElementById("no-video-media");

	18 video.addEventListener("timeupdate", function()

	19 {

	20 if (video.currentTime < 4)
	acolwell GONE FROM CHROMIUM 2014/05/23 18:26:28 ditto. Actually, I wonder if we should put this fu ditto. Actually, I wonder if we should put this functionality in some sort of helper function and make it setTimeout() based since technically the fade out isn't dependent on elapsed playback time. We just have to make sure that we are playing. I realize now that the test I added set a bad example to follow. :)
	21 return;

	22 controls = mediaControlsButton(video, "panel");

	23 testExpected("getComputedStyle(controls).opacity", 0);

	24

	25 consoleWrite("");

	26 endTest();

	27 });

	28

	29 testExpected("video.paused", true);

	30 if (!window.testRunner)

	31 return;

	32

	33 // Click the play button.

	34 var playCoords = mediaControlsButtonCoordinates(video, "play-button");

	35 var clickX = playCoords[0];

	36 var clickY = playCoords[1];

	37 eventSender.mouseMoveTo(clickX, clickY);

	38 eventSender.mouseDown();

	39 eventSender.mouseUp();

	40 testExpected("video.paused", false);

	41

	42 // Move the mouse to the upper-left corner of the video.

	43 eventSender.mouseMoveTo(video.offsetLeft + 4, video.offsetTop + 4);

	44 }

	45 </script>

	46 <body>

	47 <p>Test video element control visibility when mouse is not over element.</p>

	48 <p>This test only runs in DRT!</p>

	49

	50 <video id="no-video-media" controls loop oncanplaythrough="runTest()"></vide o>

	51 <script>

	52 setSrcById("no-video-media", findMediaFile("video", "content/test"));

	53 </script>

	54 </body>

	55 </html>

OLD	NEW