Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 297783003: Revert 271762 "Add native event testing to chromeos::EventRewrit..." (Closed)

Created:
6 years, 7 months ago by Nicolas Zea
Modified:
6 years, 7 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271762 "Add native event testing to chromeos::EventRewrit..." Breaks linux chromiumos asan lsan test EventRewriterTest.TestRewriteFunctionKeys http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29&number=1454 > Add native event testing to chromeos::EventRewriter unit tests. > > R=sadrul@chromium.org > > Review URL: https://codereview.chromium.org/270633012 TBR=kpschoedel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+764 lines, -858 lines) Patch
M trunk/src/chrome/browser/chromeos/events/event_rewriter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/events/event_rewriter_unittest.cc View 18 chunks +764 lines, -853 lines 0 comments Download
M trunk/src/ui/events/test/events_test_utils_x11.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Zea
6 years, 7 months ago (2014-05-21 01:34:17 UTC) #1
Nicolas Zea
6 years, 7 months ago (2014-05-21 01:34:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271791 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698