Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/browser/android/content_video_view.h

Issue 297773004: Add UMA to study the effect of defaulting fullscreen video to landscape mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: removing noise if user quickly switch orientations Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/android/content_video_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_video_view.h
diff --git a/content/browser/android/content_video_view.h b/content/browser/android/content_video_view.h
index faea292b5f0f9757730dcf4a385b6d044959e263..b45f38fc0c101e2abd203b06daa58321ac880bb3 100644
--- a/content/browser/android/content_video_view.h
+++ b/content/browser/android/content_video_view.h
@@ -72,6 +72,14 @@ class ContentVideoView {
void OnPlaybackComplete();
void OnExitFullscreen();
+ // Functions called to record fullscreen playback UMA metrics.
+ void RecordFullscreenPlayback(
+ JNIEnv*, jobject, bool is_portrait_video, bool is_orientation_portrait);
+ void RecordExitFullscreenPlayback(
+ JNIEnv*, jobject, bool is_portrait_video,
+ long playback_duration_in_milliseconds_before_orientation_change,
+ long playback_duration_in_milliseconds_after_orientation_change);
+
// Return the corresponing ContentVideoView Java object if any.
base::android::ScopedJavaLocalRef<jobject> GetJavaObject(JNIEnv* env);
« no previous file with comments | « no previous file | content/browser/android/content_video_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698