Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 59fabd637c9b86147b3e5715b9fd6f2b9a5e5952..21e8cc1ff0e5bca9d0b37324092801c27539f427 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -10375,6 +10375,62 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="MobileFullscreenVideo.DurationAfterPotraitRotation" |
| + units="milliseconds"> |
| + <owner>qinmin@chromium.org</owner> |
| + <summary> |
| + Android: Records the duration that a fullscreen video is played after device |
| + rotates from portrait to landscape mode. If there is no device rotation or |
|
Mark P
2014/05/21 18:17:45
I understand when the timer starts, but it's not c
qinmin
2014/05/23 01:03:58
Modified the comments a little bit. The recorded t
|
| + if the video starts with landscape mode, it is not be recorded. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="MobileFullscreenVideo.LandscapeDuration" units="milliseconds"> |
| + <owner>qinmin@chromium.org</owner> |
| + <summary> |
| + Android: Records the duration that a fullscreen video is played in landscape |
| + mode. If a video is switched from landscape to portrait mode during the |
| + playback, only the time period before the switch is accounted. |
|
Mark P
2014/05/21 18:17:45
Is this emitted when the rotation event happens or
qinmin
2014/05/23 01:03:58
Only one record is emitted during one fullscreen p
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="MobileFullscreenVideo.OrientationPortrait" |
| + enum="BooleanEnabled"> |
| + <owner>qinmin@chromium.org</owner> |
| + <summary> |
| + Android: Records the device orientation when video enters fullscreen. The |
|
Mark P
2014/05/21 18:17:45
Does it have to be playing at the time? Can it, f
Mark P
2014/05/21 18:17:45
nit: when video -> when a video
qinmin
2014/05/23 01:03:58
Done.
qinmin
2014/05/23 01:03:58
No, video doesn't needs to be playing. Screenshot
|
| + value is true if device orientation is portrait, or false otherwise. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="MobileFullscreenVideo.PortraitDuration" units="milliseconds"> |
| + <owner>qinmin@chromium.org</owner> |
| + <summary> |
| + Android: Records the duration that a fullscreen video is played in portrait |
| + mode. If a video is switched from portrait to landscape mode during the |
| + playback, only the time period before the switch is accounted. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="MobileFullscreenVideo.PortraitRotation" enum="BooleanEnabled"> |
|
Mark P
2014/05/21 18:17:45
You might want to have a LandscapeRotation for com
qinmin
2014/05/23 01:03:58
Done.
|
| + <owner>qinmin@chromium.org</owner> |
| + <summary> |
| + Android: Records the number of times that fullscreen video is switched from |
|
Mark P
2014/05/21 18:17:45
This histogram doesn't record a number as the desc
qinmin
2014/05/23 01:03:58
Done.
|
| + portrait mode to landscape mode. The value is true if a switch happens |
| + during the playback, or false otherwise. If there are multiple switches |
| + during the playback, only the first switch is recorded. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="MobileFullscreenVideo.VideoPortrait" enum="BooleanEnabled"> |
| + <owner>qinmin@chromium.org</owner> |
| + <summary> |
| + Android: Records the number of fullscreen video that have a larger height |
|
Mark P
2014/05/21 18:17:45
nit: video -> videos
qinmin
2014/05/23 01:03:58
changed to "a fullscreen video"
On 2014/05/21 18:
|
| + than width. The value is true if video height is larger than width, or false |
| + otherwise. |
|
Mark P
2014/05/21 18:17:45
This histogram need to explicitly say when it is r
qinmin
2014/05/23 01:03:58
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="MobileStartup.MobileMultiWindowInstances"> |
| <owner>dtrainor@chromium.org</owner> |
| <summary> |