headless/lib/browser/headless_url_request_context_getter.h - Issue 2977693003: Use TaskRunner passed in to URLRequestContextBuilder only for the cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_url_request_context_getter.h

Issue 2977693003: Use TaskRunner passed in to URLRequestContextBuilder only for the cache (Closed)

Patch Set: Actually, don't need to set the thread everywhere Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/headless_url_request_context_getter.h

diff --git a/headless/lib/browser/headless_url_request_context_getter.h b/headless/lib/browser/headless_url_request_context_getter.h

index 5080fa895269edb2d243c2c886d0e56e35dee299..5ee7c7fc36a314f4594530bfbc30d991fc0bb539 100644

--- a/headless/lib/browser/headless_url_request_context_getter.h

+++ b/headless/lib/browser/headless_url_request_context_getter.h

@@ -53,9 +53,6 @@ class HeadlessURLRequestContextGetter : public net::URLRequestContextGetter {

private:

scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;

- // TODO(eseckler): This should become a SequencedTaskRunner once net:: APIs

- // accept a SequencedTaskRunner, see https://crbug.com/735368.

- scoped_refptr<base::SingleThreadTaskRunner> file_task_runner_;

// The |options| object given to the constructor is not guaranteed to outlive

// this class, so we make copies of the parts we need to access on the IO