Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2977683002: Fix crash in inference (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 chunk +3 lines, -0 lines 2 comments Download
A tests/language/regress_30121_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
3 years, 5 months ago (2017-07-11 13:24:13 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2977683002/diff/1/pkg/compiler/lib/src/inferrer/inferrer_engine.dart File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right): https://codereview.chromium.org/2977683002/diff/1/pkg/compiler/lib/src/inferrer/inferrer_engine.dart#newcode395 pkg/compiler/lib/src/inferrer/inferrer_engine.dart:395: callMethod = cls.lookupMember(Identifiers.noSuchMethod_); I don't recall this changing ...
3 years, 5 months ago (2017-07-11 16:53:39 UTC) #4
Johnni Winther
https://codereview.chromium.org/2977683002/diff/1/pkg/compiler/lib/src/inferrer/inferrer_engine.dart File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right): https://codereview.chromium.org/2977683002/diff/1/pkg/compiler/lib/src/inferrer/inferrer_engine.dart#newcode395 pkg/compiler/lib/src/inferrer/inferrer_engine.dart:395: callMethod = cls.lookupMember(Identifiers.noSuchMethod_); On 2017/07/11 16:53:39, Siggi Cherem (dart-lang) ...
3 years, 5 months ago (2017-07-12 08:13:07 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-07-12 08:18:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
aa014f3b28ee724330dec1623ad96de92fd5af35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698