Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 2977663003: [vm] Support flow events in Dart_TimelineEvent. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/include/dart_tools_api.h ('k') | runtime/vm/timeline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 69b52f18c8d6c8aeff2cc648c500281f9e5596fa..e3ff1184fdabd80d6f99570fa66f0f860eddfaf6 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -6474,7 +6474,7 @@ DART_EXPORT void Dart_TimelineEvent(const char* label,
if (type < Dart_Timeline_Event_Begin) {
return;
}
- if (type > Dart_Timeline_Event_Counter) {
+ if (type > Dart_Timeline_Event_Flow_End) {
return;
}
TimelineStream* stream = Timeline::GetEmbedderStream();
@@ -6509,6 +6509,15 @@ DART_EXPORT void Dart_TimelineEvent(const char* label,
case Dart_Timeline_Event_Counter:
event->Counter(label, timestamp0);
break;
+ case Dart_Timeline_Event_Flow_Begin:
+ event->FlowBegin(label, timestamp1_or_async_id, timestamp0);
+ break;
+ case Dart_Timeline_Event_Flow_Step:
+ event->FlowStep(label, timestamp1_or_async_id, timestamp0);
+ break;
+ case Dart_Timeline_Event_Flow_End:
+ event->FlowEnd(label, timestamp1_or_async_id, timestamp0);
+ break;
default:
FATAL("Unknown Dart_Timeline_Event_Type");
}
« no previous file with comments | « runtime/include/dart_tools_api.h ('k') | runtime/vm/timeline.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698