Issue 2977663003: [vm] Support flow events in Dart_TimelineEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2977663003: [vm] Support flow events in Dart_TimelineEvent. (Closed)

Created:
3 years, 5 months ago by rmacnak

Modified:
3 years, 5 months ago

Reviewers:
zra, Chinmay

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -5 lines)			Patch
M	runtime/include/dart_tools_api.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/vm/timeline.h	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/timeline.cc	View	5 chunks	+62 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

lgtm Exposing this in dart:developer looks like it would require handling the additional phases here: ...

3 years, 5 months ago (2017-07-12 05:44:22 UTC) #3

rmacnak

3 years, 5 months ago (2017-07-12 17:18:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5a02f3819bdef541351dcd6445b71ef0ceeda68a.