Issue 297763006: Improve write barriers in optimized code.

Issue 297763006: Improve write barriers in optimized code. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer

Modified:
6 years, 6 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Improve write barriers in optimized code. Use a cheaper RecordWriteForMap() to update the write barrier for maps. And skip the value check in RecordWriteField() when we statically know that the value is in new space (and therefore has "pointers to here are interesting" flag set). R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21630

Patch Set 1 #

Patch Set 2 : REBASE #

Total comments: 4

Patch Set 3 : Ports #

Patch Set 4 : Introduce PointersToHereCheck. #

Patch Set 5 : REBASE #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+474 lines, -151 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 2 3 4	5 chunks	+16 lines, -13 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 2 3 4	5 chunks	+22 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 2 3 4	5 chunks	+95 lines, -14 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1 2 3 4	4 chunks	+11 lines, -12 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.h	View	1 2 3 4	5 chunks	+22 lines, -4 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View	1 2 3 4	4 chunks	+90 lines, -13 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2 3 4	4 chunks	+25 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3 4	3 chunks	+7 lines, -14 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 2 3 4	5 chunks	+18 lines, -5 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 2 3 4	8 chunks	+33 lines, -29 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3 4	4 chunks	+10 lines, -12 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 2 3 4	5 chunks	+24 lines, -5 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 2 3 4	6 chunks	+101 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

This is still work-in-progress, but just to give you an idea of how this is ...

6 years, 7 months ago (2014-05-21 12:20:44 UTC) #1

Hannes Payer (out of office)

I like it! Just nits... I am waiting for the ports. https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): ...

6 years, 6 months ago (2014-06-03 05:51:47 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/297763006/diff/20001/src/arm/macro-assembler-arm.cc#newcode517 src/arm/macro-assembler-arm.cc:517: // TODO(mstarzinger): Dynamic counter missing. I just copied the ...

6 years, 6 months ago (2014-06-03 07:48:02 UTC) #3

Benedikt Meurer

6 years, 6 months ago (2014-06-03 10:59:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r21630 (tree was closed).

Expand Messages | Collapse Messages