Issue 297763003: Remove the checks for component=shared_library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297763003: Remove the checks for component=shared_library. (Closed)

Created:
6 years, 7 months ago by jungshik at Google

Modified:
6 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/

Visibility:
Public.

Remove the checks for component=shared_library. The original CL is by maruel (see https://codereview.chromium.org/263823013/). I'm applying his CL to icu52. Below is maruel's CL description. This is not needed anymore, src/tools/isolate_driver.py parses the ninja files to figure out the .so/.dylib/.dll needed automatically. TBR=maruel@chromium.org BUG=336439 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271774

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -24 lines)			Patch
	M	icu.isolate	View		1 chunk	+0 lines, -24 lines	0 comments	Download

Total messages: 3 (0 generated)

jungshik at Google

Committed patchset #1 manually as r271774 (presubmit successful).

6 years, 7 months ago (2014-05-20 22:03:51 UTC) #2

M-A Ruel

6 years, 7 months ago (2014-05-21 00:39:45 UTC) #3

Message was sent while issue was closed.

lgtm

Sadly, my CL was reverted but that is going to be fixed independently so this CL
is still fine.