Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 297763002: Pepper: Remove url_info_map from trusted plugin. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Remove url_info_map from trusted plugin. This appears to be a vestigal part of some StreamAsFile() operation that no longer exists. It's not necessary to cache this file info in the plugin, as we only ever return it once. I've split this off from a bigger StreamAsFile() refactoring to make the diff smaller, to help debug Windows failures on that patch. BUG=239656 R=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M ppapi/native_client/src/trusted/plugin/plugin.h View 3 chunks +3 lines, -10 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 5 chunks +5 lines, -27 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
teravest
6 years, 7 months ago (2014-05-20 22:16:45 UTC) #1
bbudge
lgtm
6 years, 7 months ago (2014-05-21 17:38:22 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 7 months ago (2014-05-21 18:37:01 UTC) #3
teravest
6 years, 7 months ago (2014-05-21 19:21:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r271940 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698