Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2977583002: Fix handling of async patches. (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix handling of async patches. - and rewrite the only use to avoid async rewrite. Committed: https://github.com/dart-lang/sdk/commit/6ed6ac9fb9931721994ac5651997f5816a352c85

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 1 3 chunks +27 lines, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_patch.dart View 1 chunk +6 lines, -3 lines 0 comments Download
A tests/isolate/resolve_package_uri_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
3 years, 5 months ago (2017-07-10 14:07:53 UTC) #2
Johnni Winther
Committed patchset #2 (id:20001) manually as 6ed6ac9fb9931721994ac5651997f5816a352c85 (presubmit successful).
3 years, 5 months ago (2017-07-10 14:08:15 UTC) #4
floitsch
3 years, 5 months ago (2017-07-10 19:34:51 UTC) #5
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698