src/wasm/wasm-objects.cc - Issue 2977543002: [wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-objects.cc

Issue 2977543002: [wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-objects.cc

diff --git a/src/wasm/wasm-objects.cc b/src/wasm/wasm-objects.cc

index c55febcd23ea4d300c97bf92f72e6b0430cd80a3..090c61d93c2a1b3e317469a7de43169ff3975bcc 100644

--- a/src/wasm/wasm-objects.cc

+++ b/src/wasm/wasm-objects.cc

@@ -184,7 +184,7 @@ Handle<WasmTableObject> WasmTableObject::New(Isolate* isolate, uint32_t initial,

}

table_obj->set_functions(**js_functions);

DCHECK_EQ(maximum, static_cast<int>(maximum));

- table_obj->set_maximum_length(static_cast<int>(maximum));

+ table_obj->set_maximum_length(*isolate->factory()->NewNumber(maximum));

Handle<FixedArray> dispatch_tables = isolate->factory()->NewFixedArray(0);

table_obj->set_dispatch_tables(*dispatch_tables);