Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: src/wasm/module-compiler.cc

Issue 2977543002: [wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/wasm/wasm-js.cc » ('j') | src/wasm/wasm-js.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/module-compiler.cc
diff --git a/src/wasm/module-compiler.cc b/src/wasm/module-compiler.cc
index 3a988e69962eb31e3e9ddd5b1ea144ce1a654b35..4fe8d2313c8d18ef55854db4c92679f4859d1deb 100644
--- a/src/wasm/module-compiler.cc
+++ b/src/wasm/module-compiler.cc
@@ -1339,8 +1339,8 @@ int InstanceBuilder::ProcessImports(Handle<FixedArray> code_table,
}
if (table.has_max) {
- int64_t imported_max_size =
- table_instance.table_object->maximum_length();
+ int64_t imported_max_size = static_cast<int64_t>(
Clemens Hammacher 2017/07/10 10:35:48 You don't need this static_cast.
titzer 2017/07/10 10:38:23 Done.
+ table_instance.table_object->maximum_length()->Number());
if (imported_max_size < 0) {
thrower_->LinkError(
"table import %d has no maximum length, expected %d", index,
« no previous file with comments | « no previous file | src/wasm/wasm-js.cc » ('j') | src/wasm/wasm-js.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698