[wasm] Allow full u32 range for table maximum in WebAssembly.Table constructor.

test/mjsunit/wasm/table.js

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --expose-wasm
 
 'use strict';
 
 load("test/mjsunit/wasm/wasm-constants.js");
 load("test/mjsunit/wasm/wasm-module-builder.js");
 
 // Basic tests.
 
 var outOfUint32RangeValue = 1e12;
 var int32ButOob = 1073741824;
 var kMaxUint32 = (4 * 1024 * 1024 * 1024) - 1;
+var kMaxUint31 = (2 * 1024 * 1024 * 1024) - 1;
 var kV8MaxWasmTableSize = 10000000;
 
-function assertTableIsValid(table) {
+function assertTableIsValid(table, length) {
   assertSame(WebAssembly.Table.prototype, table.__proto__);
   assertSame(WebAssembly.Table, table.constructor);
   assertTrue(table instanceof Object);
   assertTrue(table instanceof WebAssembly.Table);
+  assertEquals(length, table.length);
 }
 
 (function TestConstructor() {
   assertTrue(WebAssembly.Table instanceof Function);
   assertSame(WebAssembly.Table, WebAssembly.Table.prototype.constructor);
   assertTrue(WebAssembly.Table.prototype.grow instanceof Function);
   assertTrue(WebAssembly.Table.prototype.get instanceof Function);
   assertTrue(WebAssembly.Table.prototype.set instanceof Function);
   let desc = Object.getOwnPropertyDescriptor(WebAssembly.Table.prototype, 'length');
   assertTrue(desc.get instanceof Function);
@@ skipping 16 matching lines @@
 
   assertThrows(() => new WebAssembly.Table(
     {element: "anyfunc", initial: 10, maximum: -1}), RangeError);
   assertThrows(() => new WebAssembly.Table(
     {element: "anyfunc", initial: 10, maximum: outOfUint32RangeValue}), RangeError);
   assertThrows(() => new WebAssembly.Table(
     {element: "anyfunc", initial: 10, maximum: 9}), RangeError);
 
   let table;
   table = new WebAssembly.Table({element: "anyfunc", initial: 1});
-  assertTableIsValid(table);
-  assertEquals(1, table.length);
+  assertTableIsValid(table, 1);
   assertEquals(null, table.get(0));
   assertEquals(undefined, table[0]);
 
   table = new WebAssembly.Table({element: "anyfunc", initial: "2"});
-  assertTableIsValid(table);
-  assertEquals(2, table.length);
+  assertTableIsValid(table, 2);
   assertEquals(null, table.get(0));
   assertEquals(null, table.get(1));
   assertEquals(undefined, table[0]);
   assertEquals(undefined, table[1]);
 
   table = new WebAssembly.Table({element: "anyfunc", initial: {valueOf() { return "1" }}});
-  assertTableIsValid(table);
-  assertEquals(1, table.length);
+  assertTableIsValid(table, 1);
   assertEquals(null, table.get(0));
   assertEquals(undefined, table[0]);
 
   table = new WebAssembly.Table({element: "anyfunc", initial: undefined});
-  assertTableIsValid(table);
-  assertEquals(0, table.length);
+  assertTableIsValid(table, 0);
 
   table = new WebAssembly.Table({element: "anyfunc"});
-  assertTableIsValid(table);
-  assertEquals(0, table.length);
+  assertTableIsValid(table, 0);
 
   table = new WebAssembly.Table({element: "anyfunc", maximum: 10});
-  assertTableIsValid(table);
-  assertEquals(0, table.length);
+  assertTableIsValid(table, 0);
 
   table = new WebAssembly.Table({element: "anyfunc", maximum: "10"});
-  assertTableIsValid(table);
-  assertEquals(0, table.length);
+  assertTableIsValid(table, 0);
 
   table = new WebAssembly.Table({element: "anyfunc", maximum: {valueOf() { return "10" }}});
-  assertTableIsValid(table);
-  assertEquals(0, table.length);
+  assertTableIsValid(table, 0);
 
   table = new WebAssembly.Table({element: "anyfunc", initial: 0, maximum: undefined});
-  assertTableIsValid(table);
-  assertEquals(0, table.length);
+  assertTableIsValid(table, 0);
+
+  table = new WebAssembly.Table({element: "anyfunc", maximum: kMaxUint31});
+  assertTableIsValid(table, 0);
 
   table = new WebAssembly.Table({element: "anyfunc", maximum: kMaxUint32});
-  assertTableIsValid(table);
-  assertEquals(0, table.length);
+  assertTableIsValid(table, 0);
 
   table = new WebAssembly.Table({element: "anyfunc", maximum: kV8MaxWasmTableSize + 1});
-  assertTableIsValid(table);
-  assertEquals(0, table.length);
+  assertTableIsValid(table, 0);
 })();
 
 (function TestMaximumIsReadOnce() {
   var a = true;
   var desc = {element: "anyfunc", initial: 10};
   Object.defineProperty(desc, 'maximum', {get: function() {
     if (a) {
       a = false;
       return 16;
     }
     else {
       // Change the return value on the second call so it throws.
       return -1;
     }
   }});
   let table = new WebAssembly.Table(desc);
-  assertTableIsValid(table);
+  assertTableIsValid(table, 10);
 })();
 
 (function TestMaximumDoesHasProperty() {
   var hasPropertyWasCalled = false;
   var desc = {element: "anyfunc", initial: 10};
   var proxy = new Proxy({maximum: 16}, {
     has: function(target, name) { hasPropertyWasCalled = true; }
   });
   Object.setPrototypeOf(desc, proxy);
   let table = new WebAssembly.Table(desc);
-  assertTableIsValid(table);
+  assertTableIsValid(table, 10);
 })();
 
 (function TestLength() {
   for (let i = 0; i < 10; ++i) {
     let table = new WebAssembly.Table({element: "anyfunc", initial: i});
     assertEquals(i, table.length);
   }
 
   assertThrows(() => WebAssembly.Table.prototype.length.call([]), TypeError);
 })();
@@ skipping 124 matching lines @@
   assertThrows(() => table.grow(1), RangeError);
   assertThrows(() => table.grow(-10), RangeError);
 
   assertThrows(() => WebAssembly.Table.prototype.grow.call([], 0), TypeError);
 
   table = new WebAssembly.Table(
     {element: "anyfunc", initial: 0, maximum: kV8MaxWasmTableSize});
   table.grow(kV8MaxWasmTableSize);
   assertThrows(() => table.grow(1), RangeError);
 })();