Issue 297753007: Telemetry: Profilers ignore disappearing processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297753007: Telemetry: Profilers ignore disappearing processes. (Closed)

Created:
6 years, 7 months ago by Dominik Grewe

Modified:
6 years, 7 months ago

Reviewers:
tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Telemetry: Profilers ignore disappearing processes. Make profiler code more robust by catching ProcessGoneException when listing all processes. Before the test would crash if processes disappeared between getting all PIDs and querying their name. BUG=375231 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272242

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	tools/telemetry/telemetry/core/platform/profiler/__init__.py	View		2 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/297753007/20001

6 years, 7 months ago (2014-05-22 13:38:51 UTC) #3

Message was sent while issue was closed.

Change committed as 272242

Expand Messages | Collapse Messages