Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 297753002: Revert 271721 "VS2013 Update 2" (Closed)

Created:
6 years, 7 months ago by scottmg
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271721 "VS2013 Update 2" static_library build ICEing on some builders on mini_installer. > VS2013 Update 2 > > As discussed in the linked bug, the toolchain2013.py script in > depot_tools is no longer workable (because the update for Update 2 is > supplied as a .msp that must be applied against a system-installed > VS2013). > > As such, the Express hash here is not updated. > > The hash zip referenced here was built as follows: > - Install VS2013 Update 2 on a clean VM > - Copy DIA SDK\, VC\ > - Copy DLLs from VC\redist to sys32\ and sys64\ > - Copy win8sdk unchanged from previous .zip. > - Delete various unused arm\ subdirectories > - Delete the IDE-only Snippets, etc. subdirectories in VC\ > - Patch VC\include\xtree to disable warning 4702 per request in > http://crbug.com/346399 . > > A followup change will be to write a script that does these steps > semi-automatically, hopefully for Express too, though there is the > added complication of the WDK/ATL/MFC hacking required there. In > particular, this script will not be useful for a dev to actually run > as part of runhooks, but will be a bit useful for deployment/ > documentation of the above process. > > In the interim there are no extremely-pressing reasons for Express > users to update to Update2 that I'm aware of, so they get non-Update2 > for now. > > R=iannucci@chromium.org > BUG=372451, 346399, 371847, 339215, 350639 > > Review URL: https://codereview.chromium.org/284663003 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1 line) Patch
M trunk/src/apps/shell/app_shell.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/build/get_landmines.py View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/build/toolchain_vs2013.hash View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_dll.gypi View 2 chunks +24 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 6 chunks +24 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 2 chunks +20 lines, -0 lines 0 comments Download
A + trunk/src/chrome/empty_pdb_workaround.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
6 years, 7 months ago (2014-05-20 20:13:49 UTC) #1
scottmg
6 years, 7 months ago (2014-05-20 20:13:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271737 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698