MD Bookmarks: Scroll and select items that are added to the main list

third_party/closure_compiler/externs/bookmark_manager_private.js

Index: third_party/closure_compiler/externs/bookmark_manager_private.js
diff --git a/third_party/closure_compiler/externs/bookmark_manager_private.js b/third_party/closure_compiler/externs/bookmark_manager_private.js
index d62688cc16d2a937883450ec525e93a599f556cd..ec1faf2ebf7df8420c766acb26c9abde50a3d227 100644
--- a/third_party/closure_compiler/externs/bookmark_manager_private.js
+++ b/third_party/closure_compiler/externs/bookmark_manager_private.js
@@ -90,8 +90,9 @@ chrome.bookmarkManagerPrivate.startDrag = function(idList, isFromTouch) {};
  * @param {string} parentId The ID of the folder that the drop was made
  * @param {number=} index The index of the position to drop at. If left out the
  * dropped items will be placed at the end of the existing children
+ * @param {Function=} callback

[Devlin, 2017/07/26 16:10:37]

Did you regenerate these using the script?  We have more specific typing for
function params now.

[tsergeant, 2017/07/26 23:36:39]

I did this by hand. I'm having trouble with the json_schema_compiler, where it
takes the type 'bookmarks.BookmarkTreeNode' (used in getSubtree), and rewrites
it as the type 'chrome.bookmarkManagerPrivate.bookmarks.BookmarkTreeNode', which
Closure is not happy with.

Do you know if there's a way around this? Or if this is a bug in
json_schema_compiler that we'd need to work around.

[tsergeant, 2017/07/27 03:06:19]

Ah, here's a bug for this problem: https://crbug.com/543822

[Devlin, 2017/07/27 16:36:35]

Oh, bummer.  Okay, thanks for checking!

  */
-chrome.bookmarkManagerPrivate.drop = function(parentId, index) {};
+chrome.bookmarkManagerPrivate.drop = function(parentId, index, callback) {};
 
 /**
  * Retrieves a bookmark hierarchy from the given node.  If the node id is