MD Bookmarks: Scroll and select items that are added to the main list

chrome/test/data/webui/md_bookmarks/command_manager_test.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 suite('<bookmarks-command-manager>', function() {
   var commandManager;
   var store;
   var lastCommand;
   var lastCommandIds;
+  var bmpCopyFunction;
 
   suiteSetup(function() {
     // Overwrite bookmarkManagerPrivate APIs which will crash if called with
     // fake data.
+    bmpCopyFunction = chrome.bookmarkManagerPrivate.copy;
     chrome.bookmarkManagerPrivate.copy = function() {};
     chrome.bookmarkManagerPrivate.removeTrees = function() {};
   });
 
+  suiteTeardown(function() {
+    chrome.bookmarkManagerPrivate.copy = bmpCopyFunction;
+  });
+
   setup(function() {
     var bulkChildren = [];
     for (var i = 1; i <= 20; i++) {
       var id = '3' + i;
       bulkChildren.push(createItem(id, {url: `http://${id}/`}));
     }
 
     store = new bookmarks.TestStore({
       nodes: testTree(
           createFolder(
@@ skipping 99 matching lines @@
     MockInteractions.pressAndReleaseKeyOn(document.body, '', modifier, 'c');
     commandManager.assertLastCommand('copy', ['11', '13']);
   });
 
   test('cut/paste commands trigger', function() {
     var lastCut;
     var lastPaste;
     chrome.bookmarkManagerPrivate.cut = function(idList) {
       lastCut = idList.sort();
     };
+    var bmpPasteFunction = chrome.bookmarkManagerPrivate.paste;

[calamity, 2017/07/14 04:14:40]

Can we just do this in the setup/teardown like for copy?

[tsergeant, 2017/07/14 06:39:20]

Done.

     chrome.bookmarkManagerPrivate.paste = function(selectedFolder) {
       lastPaste = selectedFolder;
     };
 
     var modifier = cr.isMac ? 'meta' : 'ctrl';
 
     store.data.selection.items = new Set(['11', '13']);
     store.notifyObservers();
 
     MockInteractions.pressAndReleaseKeyOn(document.body, '', modifier, 'x');
     assertDeepEquals(['11', '13'], lastCut);
     MockInteractions.pressAndReleaseKeyOn(document.body, '', modifier, 'v');
     assertEquals('1', lastPaste);
+
+    chrome.bookmarkManagerPrivate.paste = bmpPasteFunction;
   });
 
   test('undo and redo commands trigger', function() {
     var undoModifier = cr.isMac ? 'meta' : 'ctrl';
     var undoKey = 'z';
     var redoModifier = cr.isMac ? ['meta', 'shift'] : 'ctrl'
     var redoKey = cr.isMac ? 'Z' : 'y';
 
     MockInteractions.pressAndReleaseKeyOn(
         document.body, '', undoModifier, undoKey);
@@ skipping 264 matching lines @@
 
   test('meta-down triggers Open on Mac', function() {
     if (!cr.isMac)
       return;
 
     customClick(items[0]);
     MockInteractions.pressAndReleaseKeyOn(items[0], 0, 'meta', 'ArrowDown');
     assertEquals('11', store.data.selectedFolder);
   });
 });
+
+suite('<bookmarks-command-manager> whole page integration', function() {
+  var app;
+  var store;
+  var commandManager;
+
+  var testFolderId;
+
+  function create(bookmark) {
+    return new Promise(function(resolve) {
+      chrome.bookmarks.create(bookmark, resolve);
+    });
+  }
+
+  suiteSetup(function() {
+    var testFolder = {
+      parentId: '1',
+      title: 'Test',
+    };
+    return create(testFolder).then(function(testFolderNode) {
+      testFolderId = testFolderNode.id;
+      var testItem = {
+        parentId: testFolderId,
+        title: 'Test bookmark',
+        url: 'https://www.example.com/',
+      };
+      return Promise.all([
+        create(testItem),
+        create(testItem),
+      ]);
+    });
+  });
+
+  setup(function() {
+    store = new bookmarks.TestStore({});
+    store.replaceSingleton();
+    store.setReducersEnabled(true);
+    var promise = store.acceptInitOnce();
+    var app = document.createElement('bookmarks-app');
+    replaceBody(app);
+
+    commandManager = bookmarks.CommandManager.getInstance();
+
+    return promise.then(() => {
+      store.dispatch(bookmarks.actions.selectFolder(testFolderId));
+    });
+  });
+
+  test('paste selects newly created items', function() {
+    var displayedIdsBefore = bookmarks.util.getDisplayedList(store.data);
+    commandManager.handle(Command.SELECT_ALL, new Set());
+    commandManager.handle(Command.COPY, new Set(displayedIdsBefore));
+
+    store.expectAction('select-items');
+    commandManager.handle(Command.PASTE, new Set());
+
+    return store.waitForAction('select-items').then(function(action) {
+      var displayedIdsAfter = bookmarks.util.getDisplayedList(store.data);
+      assertEquals(4, displayedIdsAfter.length);
+
+      // The start of the list shouldn't change.
+      assertEquals(displayedIdsBefore[0], displayedIdsAfter[0]);
+      assertEquals(displayedIdsBefore[1], displayedIdsAfter[1]);
+
+      // The two pasted items should be selected at the end of the list.
+      assertEquals(action.items[0], displayedIdsAfter[2]);
+      assertEquals(action.items[1], displayedIdsAfter[3]);
+      assertEquals(2, action.items.length);
+      assertEquals(action.anchor, displayedIdsAfter[2]);
+    });
+  });
+
+  suiteTeardown(function(done) {
+    chrome.bookmarks.removeTree(testFolderId, () => done());
+  });
+});