Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

Issue 2977463002: DevTools: use 'empty' for array holes (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-inline-values-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 ObjectUI.RemoteObjectPreviewFormatter = class { 7 ObjectUI.RemoteObjectPreviewFormatter = class {
8 /** 8 /**
9 * @param {!Protocol.Runtime.PropertyPreview} a 9 * @param {!Protocol.Runtime.PropertyPreview} a
10 * @param {!Protocol.Runtime.PropertyPreview} b 10 * @param {!Protocol.Runtime.PropertyPreview} b
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 parentElement.createTextChild(': '); 160 parentElement.createTextChild(': ');
161 parentElement.appendChild(this._renderPropertyPreviewOrAccessor([property] )); 161 parentElement.appendChild(this._renderPropertyPreviewOrAccessor([property] ));
162 elementsAdded = true; 162 elementsAdded = true;
163 } 163 }
164 164
165 /** 165 /**
166 * @param {number} index 166 * @param {number} index
167 */ 167 */
168 function appendUndefined(index) { 168 function appendUndefined(index) {
169 var span = parentElement.createChild('span', 'object-value-undefined'); 169 var span = parentElement.createChild('span', 'object-value-undefined');
170 span.textContent = Common.UIString('undefined × %d', index - lastNonEmptyA rrayIndex - 1); 170 span.textContent = Common.UIString('empty × %d', index - lastNonEmptyArray Index - 1);
171 elementsAdded = true; 171 elementsAdded = true;
172 } 172 }
173 } 173 }
174 174
175 /** 175 /**
176 * @param {!Element} parentElement 176 * @param {!Element} parentElement
177 * @param {!Protocol.Runtime.ObjectPreview} preview 177 * @param {!Protocol.Runtime.ObjectPreview} preview
178 */ 178 */
179 _appendEntriesPreview(parentElement, preview) { 179 _appendEntriesPreview(parentElement, preview) {
180 for (var i = 0; i < preview.entries.length; ++i) { 180 for (var i = 0; i < preview.entries.length; ++i) {
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 preview = '{\u2026}'; 247 preview = '{\u2026}';
248 span.textContent = preview; 248 span.textContent = preview;
249 span.title = description; 249 span.title = description;
250 return span; 250 return span;
251 } 251 }
252 252
253 span.textContent = description; 253 span.textContent = description;
254 return span; 254 return span;
255 } 255 }
256 }; 256 };
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-inline-values-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698