Issue 2977453002: _ChildrenElementList implements removeRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2977453002: _ChildrenElementList implements removeRange (Closed)

Created:
3 years, 5 months ago by sra1

Modified:
3 years, 5 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

_ChildrenElementList implements removeRange This is to avoid inheriting an implementation that works incorrectly for the underlying NodeList. TBR=lrn@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b0803e1dd768385d6fbc53959d68abacafdc5631

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -9 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	2 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 3 (2 generated)

sra1

3 years, 5 months ago (2017-07-07 22:55:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b0803e1dd768385d6fbc53959d68abacafdc5631 (presubmit successful).