Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: syzygy/integration_tests/make_integration_tests_clang.py

Issue 2977433002: Fixed few small bugs (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/integration_tests/make_integration_tests_clang.py
diff --git a/syzygy/integration_tests/make_integration_tests_clang.py b/syzygy/integration_tests/make_integration_tests_clang.py
index e53715e32c5928f7f4f12e87a1c756eed0f0e5c4..0e1731fc6efef0a73a4b2669bf39cdc9fdc32177 100644
--- a/syzygy/integration_tests/make_integration_tests_clang.py
+++ b/syzygy/integration_tests/make_integration_tests_clang.py
@@ -56,8 +56,9 @@ def compile_with_asan(clang_path, source_files, src_dir, object_files,
compile_command_base.extend(compiler_flags)
for source_file, object_file in zip(source_files, object_files):
- compile_command = [compile_command_base, source_file, '-o', object_files]
-
+ compile_command = compile_command_base
Sébastien Marchand 2017/07/10 15:10:04 This doesn't work as this doesn't copy the list, s
njanevsk 2017/07/10 15:55:52 Actually the code does what it is supposed to do.
+ compile_command.extend([source_file, '-o', object_file])
+ print compile_command
Sébastien Marchand 2017/07/07 19:11:22 Remove the debugging code.
Sébastien Marchand 2017/07/10 14:58:42 You forgot to address this comment. Please make su
njanevsk 2017/07/10 15:55:52 Done.
njanevsk 2017/07/10 15:55:53 Done.
ret = subprocess.call(compile_command)
if ret != 0:
print 'ERROR: Failed compiling %s using clang-cl.' % target_name
@@ -120,7 +121,7 @@ def main():
os.path.split(os.path.relpath(source_file,
_SRC_DIR))[0],
'%s.%s.obj' % (target_name,
- os.path.splitext(os.path.basename(source_file))[0])
+ os.path.splitext(os.path.basename(source_file))[0]))
source_files = options.input_files.split()
object_files = []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698