Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2977333002: Remove several packages from DEPS (Closed)

Created:
3 years, 5 months ago by kevmoo
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove several packages from DEPS Copied the corresponding code from pkg/web_components R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/7a9cc03c090153c62562f326dd051b7be9dc519b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -28 lines) Patch
M .packages View 5 chunks +0 lines, -6 lines 0 comments Download
M DEPS View 10 chunks +0 lines, -20 lines 1 comment Download
M tests/html/utils.dart View 2 chunks +51 lines, -1 line 0 comments Download
M tests/lib_strong/html/utils.dart View 2 chunks +51 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
My understanding: the observatory has their own hard-wired set of dependencies These should be fine ...
3 years, 5 months ago (2017-07-18 04:58:56 UTC) #2
Bill Hesse
LGTM. How did you verify that the packages were not dependencies of other packages in ...
3 years, 5 months ago (2017-07-18 12:50:09 UTC) #3
kevmoo
Committed patchset #1 (id:1) manually as 7a9cc03c090153c62562f326dd051b7be9dc519b (presubmit successful).
3 years, 5 months ago (2017-07-18 14:21:24 UTC) #5
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-18 23:52:23 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2977333002/diff/1/DEPS
File DEPS (left):

https://codereview.chromium.org/2977333002/diff/1/DEPS#oldcode128
DEPS:128: "web_components_rev": "@6349e09f9118dce7ae1b309af5763745e25a9d61",
I don't believe we can remove webcomponents that easily.

Many tests are testing behavior that requires the polyfills to be loaded too.
Those tests likely have an HTML file that contains a script tag to load the .js
polyfills and the extra hooks for dart2js (search for 
`packages/web_components/webcomponents.js` and
`packages/web_components/dart_support.js`)

Powered by Google App Engine
This is Rietveld 408576698