Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart

Issue 2977303002: Issue 30179. Infer return type of static setters to 'void'. (Closed)
Patch Set: Update Analyzer inference test to handle 'void' return type. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
index 9a6e0c95bb7dddedbbbd1e4970797d35a0e075d6..27d69152aaec93f9db813f856a41a7b87e9819b6 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
@@ -251,12 +251,15 @@ class KernelProcedureBuilder extends KernelFunctionBuilder {
}
bool get isEligibleForTopLevelInference {
- if (!isInstanceMember) return false;
- if (returnType == null) return true;
- if (formals != null) {
- for (var formal in formals) {
- if (formal.type == null) return true;
+ if (isInstanceMember) {
+ if (returnType == null) return true;
+ if (formals != null) {
+ for (var formal in formals) {
+ if (formal.type == null) return true;
+ }
}
+ } else {
+ if (isSetter && returnType == null) return true;
}
return false;
}

Powered by Google App Engine
This is Rietveld 408576698