Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: dashboard/dashboard/add_histograms.py

Issue 2977283002: Ownership into GenericSets (Closed)
Patch Set: Fix reserved info reference Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/add_histograms_queue_test.py » ('j') | docs/histogram-set-json-format.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/add_histograms.py
diff --git a/dashboard/dashboard/add_histograms.py b/dashboard/dashboard/add_histograms.py
index 0cb52d1b35064db4fa30d5aca4fd9b764bc7f1ee..a4a39e3712927cb05b998c79d90a7c94b6952143 100644
--- a/dashboard/dashboard/add_histograms.py
+++ b/dashboard/dashboard/add_histograms.py
@@ -20,10 +20,10 @@ from tracing.value import histogram_set
from tracing.value.diagnostics import diagnostic
from tracing.value.diagnostics import reserved_infos
-
+SUITE_LEVEL_SPARSE_DIAGNOSTIC_NAMES = set(
benjhayden 2017/07/17 22:08:06 Did you want to go ahead and use this in this CL t
+ [reserved_infos.OWNERS.name, reserved_infos.BUG_COMPONENTS.name])
SUITE_LEVEL_SPARSE_DIAGNOSTIC_TYPES = set(
- [histogram_module.BuildbotInfo, histogram_module.DeviceInfo,
- histogram_module.Ownership])
+ [histogram_module.BuildbotInfo, histogram_module.DeviceInfo])
HISTOGRAM_LEVEL_SPARSE_DIAGNOSTIC_TYPES = set(
[histogram_module.TelemetryInfo])
SPARSE_DIAGNOSTIC_TYPES = SUITE_LEVEL_SPARSE_DIAGNOSTIC_TYPES.union(
« no previous file with comments | « no previous file | dashboard/dashboard/add_histograms_queue_test.py » ('j') | docs/histogram-set-json-format.md » ('J')

Powered by Google App Engine
This is Rietveld 408576698