Ownership into GenericSets

dashboard/dashboard/add_histograms.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """URL endpoint for adding new histograms to the dashboard."""
 
 import json
 import sys
 
 from google.appengine.api import taskqueue
 from google.appengine.ext import ndb
 
 from dashboard import add_point_queue
 from dashboard.api import api_request_handler
 from dashboard.common import datastore_hooks
 from dashboard.common import stored_object
 from dashboard.models import histogram
 from tracing.value import histogram as histogram_module
 from tracing.value import histogram_set
 from tracing.value.diagnostics import diagnostic
 from tracing.value.diagnostics import reserved_infos
 
-
+# TODO(#3718): Use names along with types to create sparse diagnostics, add here
+# owners and bug components as sparse level diagnostics
 SUITE_LEVEL_SPARSE_DIAGNOSTIC_TYPES = set(
-    [histogram_module.BuildbotInfo, histogram_module.DeviceInfo,
-     histogram_module.Ownership])
+    [histogram_module.BuildbotInfo, histogram_module.DeviceInfo])
 HISTOGRAM_LEVEL_SPARSE_DIAGNOSTIC_TYPES = set(
     [histogram_module.TelemetryInfo])
 SPARSE_DIAGNOSTIC_TYPES = SUITE_LEVEL_SPARSE_DIAGNOSTIC_TYPES.union(
     HISTOGRAM_LEVEL_SPARSE_DIAGNOSTIC_TYPES)
 
 
 TASK_QUEUE_NAME = 'histograms-queue'
 
 
 def _CheckRequest(condition, msg):
@@ skipping 183 matching lines @@
   return revision_info.chromium_commit_position[0]
 
 
 def InlineDenseSharedDiagnostics(histograms):
   # TODO(eakuefner): Delete inlined diagnostics from the set
   for hist in histograms:
     diagnostics = hist.diagnostics
     for diag in diagnostics.itervalues():
       if type(diag) not in SPARSE_DIAGNOSTIC_TYPES:
         diag.Inline()