Issue 2977163002: Revert "fix #30138, synethic nodes causing crash generating source maps"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2977163002: Revert "fix #30138, synethic nodes causing crash generating source maps" (Closed)

Created:
3 years, 5 months ago by Jennifer Messerly

Modified:
3 years, 5 months ago

Reviewers:

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "fix #30138, synethic nodes causing crash generating source maps" This reverts commit 52880e9c4c028fbd992dceac7de4499a2fb8e3be. Committed: https://github.com/dart-lang/sdk/commit/b7e3d9185d267ad378cac5b521397576a94aa7b7

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -57 lines)			Patch
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	4 chunks	+7 lines, -8 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/source_map_printer.dart	View	4 chunks	+41 lines, -36 lines	0 comments	Download
M	tests/language_strong/nullaware_opt_test.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 2 (1 generated)

Jennifer Messerly

3 years, 5 months ago (2017-07-14 22:54:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b7e3d9185d267ad378cac5b521397576a94aa7b7 (presubmit successful).