Issue 2977143002: Revert "Option to truncate integers to 64 bits, part 2"

Issue 2977143002: Revert "Option to truncate integers to 64 bits, part 2" (Closed)

Created:
3 years, 5 months ago by alexmarkov

Modified:
3 years, 5 months ago

Reviewers:
zra, regis, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Option to truncate integers to 64 bits, part 2" This reverts commit abed3c2a70856d54615890596a4a5db6cffe124f. TBR Committed: https://github.com/dart-lang/sdk/commit/776aef9ff08d93958801e1779f0984661689eef0

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -193 lines)			Patch
M	runtime/lib/integers.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/bigint_test.cc	View	8 chunks	+0 lines, -32 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	6 chunks	+2 lines, -16 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	5 chunks	+34 lines, -63 lines	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	14 chunks	+29 lines, -37 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	5 chunks	+17 lines, -27 lines	0 comments	Download
M	runtime/vm/regexp_assembler_ir.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 6 (3 generated)

alexmarkov

There is at least 1 buildbot failure, so reverting my recent change.

3 years, 5 months ago (2017-07-14 21:40:01 UTC) #3

alexmarkov

Committed patchset #1 (id:1) manually as 776aef9ff08d93958801e1779f0984661689eef0 (presubmit successful).

3 years, 5 months ago (2017-07-14 21:41:05 UTC) #5

Message was sent while issue was closed.

lgtm