Add documentationComment for Class to Kernel. Parse it. Resynthesize in Analyzer.

runtime/vm/kernel_binary_flowgraph.h

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_
 #define RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_
 
 #if !defined(DART_PRECOMPILED_RUNTIME)
 
 #include <map>
@@ skipping 1194 matching lines @@
 class ClassHelper {
  public:
   enum Fields {
     kStart,  // tag.
     kCanonicalName,
     kPosition,
     kEndPosition,
     kIsAbstract,
     kNameIndex,
     kSourceUriIndex,
+    kDocumentationCommentIndex,
     kAnnotations,
     kTypeParameters,
     kSuperClass,
     kMixinType,
     kImplementedClasses,
     kFields,
     kConstructors,
     kProcedures,
     kEnd
   };
@@ skipping 31 matching lines @@
         is_abstract_ = builder_->ReadBool();  // read is_abstract.
         if (++next_read_ == field) return;
       case kNameIndex:
         name_index_ = builder_->ReadStringReference();  // read name index.
         if (++next_read_ == field) return;
       case kSourceUriIndex:
         source_uri_index_ = builder_->ReadUInt();  // read source_uri_index.
         builder_->current_script_id_ = source_uri_index_;
         builder_->record_token_position(position_);
         if (++next_read_ == field) return;
+      case kDocumentationCommentIndex:
+        documentation_comment_index_ = builder_->ReadStringReference();

[Paul Berry, 2017/07/14 22:03:08]

Would it be better for the VM to just skip documentation comments, rather than
store them in a field that is never referenced?  They don't affect semantics so
it seems silly to bloat the VM's internal code representation with them.

[Siggi Cherem (dart-lang), 2017/07/14 22:12:43]

I share your concerns too, I like the idea of just skipping the bits.

[scheglov, 2017/07/15 00:41:57]

I agree, we can just skip it.

+        if (++next_read_ == field) return;
       case kAnnotations: {
         annotation_count_ = builder_->ReadListLength();  // read list length.
         for (intptr_t i = 0; i < annotation_count_; ++i) {
           builder_->SkipExpression();  // read ith expression.
         }
         if (++next_read_ == field) return;
       }
       case kTypeParameters:
         builder_->SkipTypeParametersList();  // read type parameters.
         if (++next_read_ == field) return;
@@ skipping 53 matching lines @@
     next_read_ = field;
     ++next_read_;
   }
 
   NameIndex canonical_name_;
   TokenPosition position_;
   TokenPosition end_position_;
   bool is_abstract_;
   StringIndex name_index_;
   intptr_t source_uri_index_;
+  StringIndex documentation_comment_index_;
   intptr_t annotation_count_;
 
  private:
   StreamingFlowGraphBuilder* builder_;
   intptr_t next_read_;
 };
 
 // Helper class that reads a kernel Library from binary.
 //
 // Use ReadUntilExcluding to read up to but not including a field.
@@ skipping 129 matching lines @@
  private:
   Reader* reader_;
   intptr_t saved_offset_;
 };
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)
 #endif  // RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_