Fixes crash in RemoteWindowTreeHostWin::HandleActivateDesktop

Fixes crash in RemoteWindowTreeHostWin::HandleActivateDesktop

Rather than route this through RemoteWindowTreeHostWin (which can now
be NULL) I'm routing it through ChromeMetroViewerProcessHost. I'm also
adding a NULL check as it may be possible in some code paths for the
host to have been disconnected and therefor NULL.

BUG=374766
TEST=none
R=ananta@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271816

[sky, 2014-05-20 14:23:05]

Also, this is the route I think we should go with all the other functions in
remote_window_tree_host_win that bounce to the
RemoteWindowTreeHostWin::instance(). I'll do that separately assuming you
approve of this.

[ananta, 2014-05-20 17:23:58]

Does it sound reasonable to send the corresponding IPCs
in the global functions like HandleActivateDesktop in the aura namespace.

[sky, 2014-05-20 17:41:41]

I don't think so. Those functions have nothing to do with
RemoteWindowTreeHostWin and don't even need one to operate. They only
need to send an ipc (and perhaps cache some values). They should be on
MetroViewProcessHost/ChromeMetroViewProcessHostAuraWin, not
RemoteWindowTreeHostWin.

  -Scott

On Tue, May 20, 2014 at 10:23 AM,  <ananta@chromium.org> wrote:
> Does it sound reasonable to send the corresponding IPCs
> in the global functions like HandleActivateDesktop in the aura namespace.
>
> https://codereview.chromium.org/297713002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-05-20 18:30:36]

Changed to follow same pattern as before. Function is now in
chrome_browser_metro_viewer_process_host_aurawin.h

[ananta, 2014-05-20 18:36:16]

lgtm

[sky, 2014-05-20 19:17:06]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-05-20 19:19:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/297713002/20001

[commit-bot: I haz the power, 2014-05-21 02:18:46]

Change committed as 271816