[wasm] Fix user properties for exported wasm functions and add extensive tests.

src/wasm/wasm-js.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api-natives.h"
 #include "src/api.h"
 #include "src/assert-scope.h"
 #include "src/ast/ast.h"
 #include "src/execution.h"
 #include "src/factory.h"
@@ skipping 850 matching lines @@
   return function;
 }
 
 void WasmJs::Install(Isolate* isolate) {
   Handle<JSGlobalObject> global = isolate->global_object();
   Handle<Context> context(global->native_context(), isolate);
   // Check if the map is already installed and do nothing otherwise.
   if (context->get(Context::WASM_FUNCTION_MAP_INDEX)->IsMap()) return;
 
   // Install Maps.
-  Handle<Map> prev_map = Handle<Map>(context->sloppy_function_map(), isolate);
+  {
+    Handle<Map> prev_map = Handle<Map>(context->sloppy_function_map(), isolate);
 
-  InstanceType instance_type = prev_map->instance_type();
-  int embedder_fields = JSObject::GetEmbedderFieldCount(*prev_map);
-  CHECK_EQ(0, embedder_fields);
-  int pre_allocated =
-      prev_map->GetInObjectProperties() - prev_map->unused_property_fields();
-  int instance_size = 0;
-  int in_object_properties = WasmExportedFunction::kFieldCount;
-  JSFunction::CalculateInstanceSizeHelper(instance_type, embedder_fields,
-                                          in_object_properties, &instance_size,
-                                          &in_object_properties);
+    InstanceType instance_type = prev_map->instance_type();
+    int embedder_fields = JSObject::GetEmbedderFieldCount(*prev_map);
+    CHECK_EQ(0, embedder_fields);
+    int pre_allocated =
+        prev_map->GetInObjectProperties() - prev_map->unused_property_fields();
+    int instance_size = 0;
+    int in_object_properties = WasmExportedFunction::kFieldCount;
+    JSFunction::CalculateInstanceSizeHelper(
+        instance_type, embedder_fields, in_object_properties, &instance_size,
+        &in_object_properties);
 
-  int unused_property_fields = in_object_properties - pre_allocated;
-  Handle<Map> map = Map::CopyInitialMap(
-      prev_map, instance_size, in_object_properties, unused_property_fields);
+    // Double-check our math.
+    CHECK_EQ(WasmExportedFunction::kSize, instance_size);
 
-  context->set_wasm_function_map(*map);
+    int unused_property_fields = in_object_properties - pre_allocated;
+    Handle<Map> map = Map::CopyInitialMap(
+        prev_map, instance_size, in_object_properties, unused_property_fields);
+    map->set_unused_property_fields(unused_property_fields -
+                                    WasmExportedFunction::kFieldCount);
+
+    // We have to install descriptors into the map, because the {instance}
+    // and {func_index} fields of the exported functions are allocated as
+    // in-object properties, which must be reflected in the map.
+    Map::EnsureDescriptorSlack(map, WasmExportedFunction::kFieldCount);
+
+    PropertyAttributes rw_attribs =
+        static_cast<PropertyAttributes>(DONT_ENUM | DONT_DELETE);
+
+    {
+      // Add instance.
+      Handle<Symbol> symbol = isolate->factory()->NewPrivateSymbol();
+      Descriptor d =
+          Descriptor::DataField(symbol, WasmExportedFunction::kInstanceIndex,
+                                rw_attribs, Representation::Tagged());
+      map->AppendDescriptor(&d);
+    }
+
+    {
+      // Add function_index.
+      Handle<Symbol> symbol = isolate->factory()->NewPrivateSymbol();
+      Descriptor d = Descriptor::DataField(
+          symbol, WasmExportedFunction::kFunctionIndexIndex, rw_attribs,
+          Representation::Tagged());
+      map->AppendDescriptor(&d);
+    }
+
+    context->set_wasm_function_map(*map);
+// Double-check we created a proper map.
+#if DEBUG
+    map->HeapObjectVerify();
+#endif
+  }
 
   Factory* factory = isolate->factory();
 
   // Install the JS API.
 
   // Setup WebAssembly
   Handle<String> name = v8_str(isolate, "WebAssembly");
   Handle<JSFunction> cons = factory->NewFunction(isolate->strict_function_map(),
                                                  name, MaybeHandle<Code>());
   JSFunction::SetPrototype(cons, isolate->initial_object_prototype());
@@ skipping 96 matching lines @@
       isolate->native_context()->wasm_link_error_function());
   JSObject::AddProperty(webassembly, isolate->factory()->LinkError_string(),
                         link_error, attributes);
   Handle<JSFunction> runtime_error(
       isolate->native_context()->wasm_runtime_error_function());
   JSObject::AddProperty(webassembly, isolate->factory()->RuntimeError_string(),
                         runtime_error, attributes);
 }
 }  // namespace internal
 }  // namespace v8