Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: components/policy/core/common/cloud/cloud_policy_client_unittest.cc

Issue 2977033002: Mixed Licenses Enrollment (Closed)
Patch Set: Fix last nit Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/cloud_policy_client_unittest.cc
diff --git a/components/policy/core/common/cloud/cloud_policy_client_unittest.cc b/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
index de6189019b62cd1c46cee98b1a380dfb65f8c766..56e3374da580608a911c43ad42fb7efe9e55b14d 100644
--- a/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
+++ b/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
@@ -431,7 +431,8 @@ TEST_F(CloudPolicyClientTest, RegistrationAndPolicyFetch) {
EXPECT_CALL(observer_, OnRegistrationStateChanged(_));
client_->Register(em::DeviceRegisterRequest::USER,
em::DeviceRegisterRequest::FLAVOR_USER_REGISTRATION,
- kOAuthToken, std::string(), std::string(), std::string());
+ em::LicenseType::UNDEFINED, kOAuthToken, std::string(),
+ std::string(), std::string());
EXPECT_TRUE(client_->is_registered());
EXPECT_FALSE(client_->GetPolicyFor(policy_type_, std::string()));
EXPECT_EQ(DM_STATUS_SUCCESS, client_->status());
@@ -447,9 +448,11 @@ TEST_F(CloudPolicyClientTest, RegistrationWithCertificateAndPolicyFetch) {
ExpectCertBasedRegistration();
fake_signing_service_.set_success(true);
EXPECT_CALL(observer_, OnRegistrationStateChanged(_));
- client_->RegisterWithCertificate(em::DeviceRegisterRequest::DEVICE,
+ client_->RegisterWithCertificate(
+ em::DeviceRegisterRequest::DEVICE,
em::DeviceRegisterRequest::FLAVOR_ENROLLMENT_ATTESTATION,
- kEnrollmentCertificate, std::string(), std::string(), std::string());
+ em::LicenseType::UNDEFINED, kEnrollmentCertificate, std::string(),
+ std::string(), std::string());
EXPECT_TRUE(client_->is_registered());
EXPECT_FALSE(client_->GetPolicyFor(policy_type_, std::string()));
EXPECT_EQ(DM_STATUS_SUCCESS, client_->status());
@@ -464,9 +467,11 @@ TEST_F(CloudPolicyClientTest, RegistrationWithCertificateAndPolicyFetch) {
TEST_F(CloudPolicyClientTest, RegistrationWithCertificateFailToSignRequest) {
fake_signing_service_.set_success(false);
EXPECT_CALL(observer_, OnClientError(_));
- client_->RegisterWithCertificate(em::DeviceRegisterRequest::DEVICE,
+ client_->RegisterWithCertificate(
+ em::DeviceRegisterRequest::DEVICE,
em::DeviceRegisterRequest::FLAVOR_ENROLLMENT_ATTESTATION,
- kEnrollmentCertificate, std::string(), std::string(), std::string());
+ em::LicenseType::UNDEFINED, kEnrollmentCertificate, std::string(),
+ std::string(), std::string());
EXPECT_FALSE(client_->is_registered());
EXPECT_EQ(DM_STATUS_CANNOT_SIGN_REQUEST, client_->status());
}
@@ -483,7 +488,8 @@ TEST_F(CloudPolicyClientTest, RegistrationParametersPassedThrough) {
EXPECT_CALL(observer_, OnRegistrationStateChanged(_));
client_->Register(em::DeviceRegisterRequest::USER,
em::DeviceRegisterRequest::FLAVOR_ENROLLMENT_MANUAL,
- kOAuthToken, kClientID, kRequisition, kStateKey);
+ em::LicenseType::UNDEFINED, kOAuthToken, kClientID,
+ kRequisition, kStateKey);
EXPECT_EQ(kClientID, client_id_);
}
@@ -494,7 +500,8 @@ TEST_F(CloudPolicyClientTest, RegistrationNoToken) {
EXPECT_CALL(observer_, OnClientError(_));
client_->Register(em::DeviceRegisterRequest::USER,
em::DeviceRegisterRequest::FLAVOR_USER_REGISTRATION,
- kOAuthToken, std::string(), std::string(), std::string());
+ em::LicenseType::UNDEFINED, kOAuthToken, std::string(),
+ std::string(), std::string());
EXPECT_FALSE(client_->is_registered());
EXPECT_FALSE(client_->GetPolicyFor(policy_type_, std::string()));
EXPECT_EQ(DM_STATUS_RESPONSE_DECODING_ERROR, client_->status());
@@ -509,7 +516,8 @@ TEST_F(CloudPolicyClientTest, RegistrationFailure) {
EXPECT_CALL(observer_, OnClientError(_));
client_->Register(em::DeviceRegisterRequest::USER,
em::DeviceRegisterRequest::FLAVOR_USER_REGISTRATION,
- kOAuthToken, std::string(), std::string(), std::string());
+ em::LicenseType::UNDEFINED, kOAuthToken, std::string(),
+ std::string(), std::string());
EXPECT_FALSE(client_->is_registered());
EXPECT_FALSE(client_->GetPolicyFor(policy_type_, std::string()));
EXPECT_EQ(DM_STATUS_REQUEST_FAILED, client_->status());
@@ -530,7 +538,8 @@ TEST_F(CloudPolicyClientTest, RetryRegistration) {
MatchProto(registration_request_)));
client_->Register(em::DeviceRegisterRequest::USER,
em::DeviceRegisterRequest::FLAVOR_USER_REGISTRATION,
- kOAuthToken, std::string(), std::string(), std::string());
+ em::LicenseType::UNDEFINED, kOAuthToken, std::string(),
+ std::string(), std::string());
EXPECT_FALSE(client_->is_registered());
Mock::VerifyAndClearExpectations(&service_);

Powered by Google App Engine
This is Rietveld 408576698